| Message ID | 20250109-dt-type-warnings-v1-0-0150e32e716c@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | device property: Warn on (of|fwnode|device)_property_read_bool() for non-boolean properties | expand |
On Thu, Jan 09, 2025 at 01:42:04PM -0600, Rob Herring (Arm) wrote: > This series makes using (of|fwnode|device)_property_read_bool() on > non-boolean properties give a warning when used with DT. This has been > deprecated behavior for a while now. Soon we will add yet another > variant of this function with a Rust binding[1]. > > Why not put the warning in the fwnode code? The fwnode code doesn't know > the property's type as that depends on the firmware. For DT, a boolean > is a property with no value. > > Perhaps the ACPI backend should have a warning too? I looked briefly at > it, but I don't have a clue how or if that can be detected. Doesn't look > like there's a specific type for booleans. In any case, that would be an > additional change on top of this series. ACPI doesn't have such a concept, i.e. there is no separate "boolean" type. All properties must have a value, we just ignore its content in case of _read_bool() API, so from ACPI perspective this _read_bool() is purely SW concept.
This series makes using (of|fwnode|device)_property_read_bool() on non-boolean properties give a warning when used with DT. This has been deprecated behavior for a while now. Soon we will add yet another variant of this function with a Rust binding[1]. Why not put the warning in the fwnode code? The fwnode code doesn't know the property's type as that depends on the firmware. For DT, a boolean is a property with no value. Perhaps the ACPI backend should have a warning too? I looked briefly at it, but I don't have a clue how or if that can be detected. Doesn't look like there's a specific type for booleans. In any case, that would be an additional change on top of this series. [1] https://lore.kernel.org/all/20241025-rust-platform-dev-v1-2-0df8dcf7c20b@kernel.org/ Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- Rob Herring (Arm) (2): device property: Split property reading bool and presence test ops of: Warn when of_property_read_bool() is used on non-boolean properties drivers/acpi/property.c | 1 + drivers/base/property.c | 38 ++++++++++++++++++++++++++++++++++++++ drivers/base/swnode.c | 1 + drivers/of/property.c | 33 +++++++++++++++++++++++++++++++++ include/linux/fwnode.h | 3 +++ include/linux/of.h | 29 ++++++++++------------------- include/linux/property.h | 15 +++------------ 7 files changed, 89 insertions(+), 31 deletions(-) --- base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 change-id: 20250109-dt-type-warnings-efe52d977bb2 Best regards,