| Message ID | 20250112-airoha_ets_priomap-v1-1-fb616de159ba@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: airoha: Enforce ETS Qdisc priomap | expand |
hello Lorenzo, thanks for following up! On Sun, Jan 12, 2025 at 07:32:45PM +0100, Lorenzo Bianconi wrote: > EN7581 SoC supports fixed QoS band priority where WRR queues have lowest > priorities with respect to SP ones. > E.g: WRR0, WRR1, .., WRRm, SP0, SP1, .., SPn > > Enforce ETS Qdisc priomap according to the hw capabilities. > > Suggested-by: Davide Caratti <dcaratti@redhat.com> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Reviewed-by: Davide Caratti <dcaratti@redhat.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 12 Jan 2025 19:32:45 +0100 you wrote: > EN7581 SoC supports fixed QoS band priority where WRR queues have lowest > priorities with respect to SP ones. > E.g: WRR0, WRR1, .., WRRm, SP0, SP1, .., SPn > > Enforce ETS Qdisc priomap according to the hw capabilities. > > Suggested-by: Davide Caratti <dcaratti@redhat.com> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > > [...] Here is the summary with links: - [net-next] net: airoha: Enforce ETS Qdisc priomap https://git.kernel.org/netdev/net-next/c/b56e4d660a96 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c index a30c417d66f2f9b0958fe1dd3829fb9ac530a34c..415d784de741c991fa521243783860dee1ed0bfa 100644 --- a/drivers/net/ethernet/mediatek/airoha_eth.c +++ b/drivers/net/ethernet/mediatek/airoha_eth.c @@ -2793,7 +2793,7 @@ static int airoha_qdma_set_tx_ets_sched(struct airoha_gdm_port *port, struct tc_ets_qopt_offload_replace_params *p = &opt->replace_params; enum tx_sched_mode mode = TC_SCH_SP; u16 w[AIROHA_NUM_QOS_QUEUES] = {}; - int i, nstrict = 0; + int i, nstrict = 0, nwrr, qidx; if (p->bands > AIROHA_NUM_QOS_QUEUES) return -EINVAL; @@ -2807,7 +2807,20 @@ static int airoha_qdma_set_tx_ets_sched(struct airoha_gdm_port *port, if (nstrict == AIROHA_NUM_QOS_QUEUES - 1) return -EINVAL; - for (i = 0; i < p->bands - nstrict; i++) + /* EN7581 SoC supports fixed QoS band priority where WRR queues have + * lowest priorities with respect to SP ones. + * e.g: WRR0, WRR1, .., WRRm, SP0, SP1, .., SPn + */ + nwrr = p->bands - nstrict; + qidx = nstrict && nwrr ? nstrict : 0; + for (i = 1; i <= p->bands; i++) { + if (p->priomap[i % AIROHA_NUM_QOS_QUEUES] != qidx) + return -EINVAL; + + qidx = i == nwrr ? 0 : qidx + 1; + } + + for (i = 0; i < nwrr; i++) w[i] = p->weights[nstrict + i]; if (!nstrict)
EN7581 SoC supports fixed QoS band priority where WRR queues have lowest priorities with respect to SP ones. E.g: WRR0, WRR1, .., WRRm, SP0, SP1, .., SPn Enforce ETS Qdisc priomap according to the hw capabilities. Suggested-by: Davide Caratti <dcaratti@redhat.com> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/ethernet/mediatek/airoha_eth.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) --- base-commit: 7d0da8f862340c5f42f0062b8560b8d0971a6ac4 change-id: 20250112-airoha_ets_priomap-255264a48aff Best regards,