| Message ID | 20250112133953.10404-2-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v5,1/4] clk: en7523: Rework clock handling for different clock numbers | expand |
Quoting Christian Marangi (2025-01-12 05:39:38) > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and > should not be placed here. Value is derived internally in the user > driver. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Applied to clk-next
Subject says EN7581.... Quoting Christian Marangi (2025-01-12 05:39:38) > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and > should not be placed here. Value is derived internally in the user > driver. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes v5: > - Add ack tag > Changes v4: > - Move to patch 2 (improves bisectability) > Changes v3: > - Add this patch > > include/dt-bindings/clock/en7523-clk.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > index 717d23a5e5ae..28e56745ccff 100644 > --- a/include/dt-bindings/clock/en7523-clk.h > +++ b/include/dt-bindings/clock/en7523-clk.h > @@ -12,6 +12,4 @@ > #define EN7523_CLK_CRYPTO 6 > #define EN7523_CLK_PCIE 7 > > -#define EN7523_NUM_CLOCKS 8 But this is EN7523 drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function) 539 | clk_data->num = EN7523_NUM_CLOCKS; | ^~~~~~~~~~~~~~~~~
On Mon, Jan 13, 2025 at 01:33:35PM -0800, Stephen Boyd wrote: > Subject says EN7581.... > > Quoting Christian Marangi (2025-01-12 05:39:38) > > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and > > should not be placed here. Value is derived internally in the user > > driver. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes v5: > > - Add ack tag > > Changes v4: > > - Move to patch 2 (improves bisectability) > > Changes v3: > > - Add this patch > > > > include/dt-bindings/clock/en7523-clk.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > index 717d23a5e5ae..28e56745ccff 100644 > > --- a/include/dt-bindings/clock/en7523-clk.h > > +++ b/include/dt-bindings/clock/en7523-clk.h > > @@ -12,6 +12,4 @@ > > #define EN7523_CLK_CRYPTO 6 > > #define EN7523_CLK_PCIE 7 > > > > -#define EN7523_NUM_CLOCKS 8 > > But this is EN7523 > > drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function) > 539 | clk_data->num = EN7523_NUM_CLOCKS; > | ^~~~~~~~~~~~~~~~~ Hi Stephen, the same define is used for both EN7523 and EN7581, do you want me to resubmit with a better description? Both clock are updated so no regression.
Quoting Christian Marangi (2025-01-13 13:37:56) > On Mon, Jan 13, 2025 at 01:33:35PM -0800, Stephen Boyd wrote: > > Subject says EN7581.... > > > > Quoting Christian Marangi (2025-01-12 05:39:38) > > > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and > > > should not be placed here. Value is derived internally in the user > > > driver. > > > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > Changes v5: > > > - Add ack tag > > > Changes v4: > > > - Move to patch 2 (improves bisectability) > > > Changes v3: > > > - Add this patch > > > > > > include/dt-bindings/clock/en7523-clk.h | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > > index 717d23a5e5ae..28e56745ccff 100644 > > > --- a/include/dt-bindings/clock/en7523-clk.h > > > +++ b/include/dt-bindings/clock/en7523-clk.h > > > @@ -12,6 +12,4 @@ > > > #define EN7523_CLK_CRYPTO 6 > > > #define EN7523_CLK_PCIE 7 > > > > > > -#define EN7523_NUM_CLOCKS 8 > > > > But this is EN7523 > > > > drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function) > > 539 | clk_data->num = EN7523_NUM_CLOCKS; > > | ^~~~~~~~~~~~~~~~~ > > Hi Stephen, > > the same define is used for both EN7523 and EN7581, do you want me to resubmit with a > better description? > > Both clock are updated so no regression. > Please resubmit the entire patchset. It doesn't compile.
On Mon, Jan 13, 2025 at 01:53:46PM -0800, Stephen Boyd wrote: > Quoting Christian Marangi (2025-01-13 13:37:56) > > On Mon, Jan 13, 2025 at 01:33:35PM -0800, Stephen Boyd wrote: > > > Subject says EN7581.... > > > > > > Quoting Christian Marangi (2025-01-12 05:39:38) > > > > Drop NUM_CLOCKS define for EN7581 include. This is not a binding and > > > > should not be placed here. Value is derived internally in the user > > > > driver. > > > > > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > Changes v5: > > > > - Add ack tag > > > > Changes v4: > > > > - Move to patch 2 (improves bisectability) > > > > Changes v3: > > > > - Add this patch > > > > > > > > include/dt-bindings/clock/en7523-clk.h | 2 -- > > > > 1 file changed, 2 deletions(-) > > > > > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > > > index 717d23a5e5ae..28e56745ccff 100644 > > > > --- a/include/dt-bindings/clock/en7523-clk.h > > > > +++ b/include/dt-bindings/clock/en7523-clk.h > > > > @@ -12,6 +12,4 @@ > > > > #define EN7523_CLK_CRYPTO 6 > > > > #define EN7523_CLK_PCIE 7 > > > > > > > > -#define EN7523_NUM_CLOCKS 8 > > > > > > But this is EN7523 > > > > > > drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function) > > > 539 | clk_data->num = EN7523_NUM_CLOCKS; > > > | ^~~~~~~~~~~~~~~~~ > > > > Hi Stephen, > > > > the same define is used for both EN7523 and EN7581, do you want me to resubmit with a > > better description? > > > > Both clock are updated so no regression. > > > > Please resubmit the entire patchset. It doesn't compile. Hope I don't get annoying and sorry for this extra mail. I can't repro the compile error, it seems patch 1 of this series wasn't applied and changes were tested only with patch 2? Patch 2 depends on patch 1 as we drop the define.
Quoting Christian Marangi (2025-01-13 14:17:49) > On Mon, Jan 13, 2025 at 01:53:46PM -0800, Stephen Boyd wrote: > > > > Please resubmit the entire patchset. It doesn't compile. > > Hope I don't get annoying and sorry for this extra mail. No worries. > > I can't repro the compile error, it seems patch 1 of this series wasn't > applied and changes were tested only with patch 2? > > Patch 2 depends on patch 1 as we drop the define. > I applied the first patch, but on top of v6.13-rc1 like all other patches that don't tell me their base. What's the base of the patch series? Please resend with a cover letter and use --base=<commitish> when formatting the patch series. When I applied the first patch I got this diffstat drivers/clk/clk-en7523.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) so I suspect I'm missing something in clk-fixes for this patch series. Please call out dependencies in the cover letter.
On Mon, Jan 13, 2025 at 02:45:21PM -0800, Stephen Boyd wrote: > Quoting Christian Marangi (2025-01-13 14:17:49) > > On Mon, Jan 13, 2025 at 01:53:46PM -0800, Stephen Boyd wrote: > > > > > > Please resubmit the entire patchset. It doesn't compile. > > > > Hope I don't get annoying and sorry for this extra mail. > > No worries. > > > > > I can't repro the compile error, it seems patch 1 of this series wasn't > > applied and changes were tested only with patch 2? > > > > Patch 2 depends on patch 1 as we drop the define. > > > > I applied the first patch, but on top of v6.13-rc1 like all other > patches that don't tell me their base. > > What's the base of the patch series? Please resend with a cover letter > and use --base=<commitish> when formatting the patch series. When I > applied the first patch I got this diffstat > > drivers/clk/clk-en7523.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > so I suspect I'm missing something in clk-fixes for this patch series. > Please call out dependencies in the cover letter. Indeed v6.13-rc1 didn't had the counted_by fix. I referenced the clk-next base branch and sent v6 with the cover letter. Hope it's clear now.
diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h index 717d23a5e5ae..28e56745ccff 100644 --- a/include/dt-bindings/clock/en7523-clk.h +++ b/include/dt-bindings/clock/en7523-clk.h @@ -12,6 +12,4 @@ #define EN7523_CLK_CRYPTO 6 #define EN7523_CLK_PCIE 7 -#define EN7523_NUM_CLOCKS 8 - #endif /* _DT_BINDINGS_CLOCK_AIROHA_EN7523_H_ */