| Message ID | 20250113-sm8750_usb_master-v1-3-09afe1dc2524@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom: Introduce USB support for SM8750 | expand |
On Mon, 13 Jan 2025 13:52:09 -0800, Melody Olvera wrote: > From: Wesley Cheng <quic_wcheng@quicinc.com> > > SM8750 uses the Synopsys DWC3 controller. Add this to the compatibles list > to utilize the DWC3 QCOM and DWC3 core framework. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250113-sm8750_usb_master-v1-3-09afe1dc2524@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Jan 13, 2025 at 01:52:09PM -0800, Melody Olvera wrote: > From: Wesley Cheng <quic_wcheng@quicinc.com> > > SM8750 uses the Synopsys DWC3 controller. Add this to the compatibles list > to utilize the DWC3 QCOM and DWC3 core framework. We see that from the diff. Say something which we do not see, e.g. differences, why is it not compatible with older variant or why interrupts are not fixed. This comment applies to all the commits here. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index 8fd02e8aaaa5e74adbac1a4a722d0fe46ccbcc59..45b32db08edbfa8d6ee8594c550dcc688974e67e 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -54,6 +54,7 @@ properties: - qcom,sm8450-dwc3 - qcom,sm8550-dwc3 - qcom,sm8650-dwc3 + - qcom,sm8750-dwc3 - qcom,x1e80100-dwc3 - qcom,x1e80100-dwc3-mp - const: qcom,dwc3 @@ -353,6 +354,7 @@ allOf: - qcom,sm8450-dwc3 - qcom,sm8550-dwc3 - qcom,sm8650-dwc3 + - qcom,sm8750-dwc3 then: properties: clocks: @@ -494,6 +496,7 @@ allOf: - qcom,sm8450-dwc3 - qcom,sm8550-dwc3 - qcom,sm8650-dwc3 + - qcom,sm8750-dwc3 then: properties: interrupts: