| Message ID | 20250110161733.2515332-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 | expand |
Hi Frank, Am Freitag, 10. Januar 2025, 17:17:32 CET schrieb Frank Li: > This controller support scalable data lanes from 1 to 4. Add the > 'data-lanes' property to configure the number of MIPI display panel lanes > selected for boards. > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. > > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> I've had a similar patch WIP. Looks good to me. For the record I based my local change according to commit 54df4868fb728 ("dt-bindings: samsung,mipi-dsim: Use port-base reference") Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Change from v1 to v2 > - Add the reason why need 'data-lanes' property in commit message. > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 350fb8f400f02..5952e6448ed47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -111,11 +111,27 @@ properties: > unevaluatedProperties: false > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: > DSI output port node to the panel or the next bridge > in the chain > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > required: > - port@0 > - port@1 >
On Fri, Jan 10, 2025 at 11:17:32AM -0500, Frank Li wrote: > This controller support scalable data lanes from 1 to 4. Add the > 'data-lanes' property to configure the number of MIPI display panel lanes > selected for boards. > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. > > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change from v1 to v2 > - Add the reason why need 'data-lanes' property in commit message. > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml index 350fb8f400f02..5952e6448ed47 100644 --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml @@ -111,11 +111,27 @@ properties: unevaluatedProperties: false port@1: - $ref: /schemas/graph.yaml#/properties/port + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false description: DSI output port node to the panel or the next bridge in the chain + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: array of physical DSI data lane indexes. + minItems: 1 + items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + required: - port@0 - port@1
This controller support scalable data lanes from 1 to 4. Add the 'data-lanes' property to configure the number of MIPI display panel lanes selected for boards. Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' property referencing video-interfaces.yaml. Allow 'data-lanes' values 1, 2, 3, and 4 for port@1. Fix below CHECK_DTB warnings: arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v1 to v2 - Add the reason why need 'data-lanes' property in commit message. --- .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)