diff mbox series

ASoC: soc-dapm: remove !card check from snd_soc_dapm_set_bias_level()

Message ID 877c6ytd9t.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Commit 41f1d2bd4998829341cdada022ede610068a0f33
Headers show
Series ASoC: soc-dapm: remove !card check from snd_soc_dapm_set_bias_level() | expand

Commit Message

Kuninori Morimoto Jan. 14, 2025, 1:06 a.m. UTC
dapm is setup by snd_soc_dapm_init(), thus dapm->card never been NULL.
We don't need if (!card) check for it.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-dapm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Jan. 14, 2025, 4:35 p.m. UTC | #1
On Tue, 14 Jan 2025 01:06:22 +0000, Kuninori Morimoto wrote:
> dapm is setup by snd_soc_dapm_init(), thus dapm->card never been NULL.
> We don't need if (!card) check for it.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-dapm: remove !card check from snd_soc_dapm_set_bias_level()
      commit: 41f1d2bd4998829341cdada022ede610068a0f33

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 99521c784a9b1..c0d2c8afe92c8 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -730,7 +730,7 @@  static int snd_soc_dapm_set_bias_level(struct snd_soc_dapm_context *dapm,
 	if (ret != 0)
 		goto out;
 
-	if (!card || dapm != &card->dapm)
+	if (dapm != &card->dapm)
 		ret = snd_soc_dapm_force_bias_level(dapm, level);
 
 	if (ret != 0)