[0/3] selftests: mptcp: Fix various issues in main_loop

Message

Cong Liu Jan. 13, 2025, 8:52 a.m. UTC

Fix several issues in the mptcp connect test's main_loop function.

 - Fix a bug where the wrong file descriptor was being checked for errors
 - Fix the input file descriptor lifecycle in the reconnection loop to
   prevent use of invalid fd
 - Add proper resource cleanup in error paths

Cong Liu (3):
  selftests: mptcp: Fix incorrect file descriptor check in main_loop
  selftests: mptcp: Fix input fd lifecycle in reconnection loop
  selftests: mptcp: Clean up resources properly in main_loop

 .../selftests/net/mptcp/mptcp_connect.c        | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)


base-commit: 2b88851f583d3c4e40bcd40cfe1965241ec229dd

Comments

Matthieu Baerts Jan. 14, 2025, 6:16 p.m. UTC | #1

Hi Cong Liu,

On 13/01/2025 09:52, Cong Liu wrote:
> Fix several issues in the mptcp connect test's main_loop function.
> 
>  - Fix a bug where the wrong file descriptor was being checked for errors
>  - Fix the input file descriptor lifecycle in the reconnection loop to
>    prevent use of invalid fd
>  - Add proper resource cleanup in error paths

Thank you for these fixes!

Please note that when sending patches to the Netdev mailing list, it is
asked to follow some specific rules, e.g.

- designate your patch to a tree - [PATCH net] or [PATCH net-next]
- for fixes the Fixes: tag is required, regardless of the tree

https://docs.kernel.org/process/maintainer-netdev.html

If I'm not mistaken, it looks like you have here fixes for net, and the
Fixes tag is missing.

Do you mind sending a v2 with this being fixed please? Because these
fixes are not urgent, do you mind sending them only to the MPTCP ML for
the moment, and not to the other ones (and no other people in CC).

> Cong Liu (3):
>   selftests: mptcp: Fix incorrect file descriptor check in main_loop
>   selftests: mptcp: Fix input fd lifecycle in reconnection loop
>   selftests: mptcp: Clean up resources properly in main_loop
> 
>  .../selftests/net/mptcp/mptcp_connect.c        | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> 
> base-commit: 2b88851f583d3c4e40bcd40cfe1965241ec229dd

Note that this base-commit doesn't seem to exist. Because of that, our
MPTCP CI was not able to automatically apply this commit.

Talking about our CI, it looks like that 'mptcp_connect' now crashes in
some cases with:

  free(): double free detected in tcache 2

Do you mind checking this please?

https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12751035845

pw-bot: cr

Cheers,
Matt