diff mbox series

loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported

Message ID 20250114161729.77142-1-arulpandiyan.vadivel@siemens.com (mailing list archive)
State New
Headers show
Series loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported | expand

Commit Message

Arulpandiyan Vadivel Jan. 14, 2025, 4:17 p.m. UTC
Updated the MODULE_COMPRESS_NONE with MODULE_COMPRESS as it was no longer
available from kernel modules.

Fixes: c7ff693fa209 ("module: Split modules_install compression and in-kernel decompression")
Signed-off-by: Arulpandiyan Vadivel <arulpandiyan.vadivel@siemens.com>
---
Changes in v2:
Reword the commit message
Modify logic and add Fixes tag.
---
 security/loadpin/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Moore Jan. 15, 2025, 3:20 a.m. UTC | #1
On Tue, Jan 14, 2025 at 11:16 AM Arulpandiyan Vadivel
<arulpandiyan.vadivel@siemens.com> wrote:
>
> Updated the MODULE_COMPRESS_NONE with MODULE_COMPRESS as it was no longer
> available from kernel modules.
>
> Fixes: c7ff693fa209 ("module: Split modules_install compression and in-kernel decompression")
> Signed-off-by: Arulpandiyan Vadivel <arulpandiyan.vadivel@siemens.com>
> ---
> Changes in v2:
> Reword the commit message
> Modify logic and add Fixes tag.
> ---
>  security/loadpin/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

For what it's worth, this looks fine to me.

Reviewed-by: Paul Moore <paul@paul-moore.com>

> diff --git a/security/loadpin/Kconfig b/security/loadpin/Kconfig
> index 848f8b4a60190..d82bcdb34cc8a 100644
> --- a/security/loadpin/Kconfig
> +++ b/security/loadpin/Kconfig
> @@ -16,7 +16,7 @@ config SECURITY_LOADPIN_ENFORCE
>         depends on SECURITY_LOADPIN
>         # Module compression breaks LoadPin unless modules are decompressed in
>         # the kernel.
> -       depends on !MODULES || (MODULE_COMPRESS_NONE || MODULE_DECOMPRESS)
> +       depends on !MODULES || (!MODULE_COMPRESS || MODULE_DECOMPRESS)
>         help
>           If selected, LoadPin will enforce pinning at boot. If not
>           selected, it can be enabled at boot with the kernel parameter
> --
> 2.39.5
diff mbox series

Patch

diff --git a/security/loadpin/Kconfig b/security/loadpin/Kconfig
index 848f8b4a60190..d82bcdb34cc8a 100644
--- a/security/loadpin/Kconfig
+++ b/security/loadpin/Kconfig
@@ -16,7 +16,7 @@  config SECURITY_LOADPIN_ENFORCE
 	depends on SECURITY_LOADPIN
 	# Module compression breaks LoadPin unless modules are decompressed in
 	# the kernel.
-	depends on !MODULES || (MODULE_COMPRESS_NONE || MODULE_DECOMPRESS)
+	depends on !MODULES || (!MODULE_COMPRESS || MODULE_DECOMPRESS)
 	help
 	  If selected, LoadPin will enforce pinning at boot. If not
 	  selected, it can be enabled at boot with the kernel parameter