diff mbox series

[v1,2/2] dt-bindings: hwmon: Add support for NCT7716, NCT7717 and NCT7718 in lm90

Message ID 20250110082612.4107571-3-a0282524688@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series hwmon: lm90: Add support for NCT7716, NCT7717 and NCT7718 | expand

Commit Message

Ming Yu Jan. 10, 2025, 8:26 a.m. UTC
This will allow binding the driver with the device from the device tree.

NCT7716 and NCT7717 do not support to add temperature offset.
The maximum offset supported by NCT7718 is 127875 millicelsius

Signed-off-by: Ming Yu <a0282524688@gmail.com>
---
 Documentation/devicetree/bindings/hwmon/national,lm90.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski Jan. 10, 2025, 9:29 a.m. UTC | #1
On 10/01/2025 09:26, Ming Yu wrote:
> This will allow binding the driver with the device from the device tree.

Rather explain the hardware, because above is not really correct - this
patch does not allow that.

Anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Ming Yu Jan. 15, 2025, 7:38 a.m. UTC | #2
Dear Krzysztof,

Thank you for reviewing.
I will include hardware description to commit message in the next patch.


Best regards,
Ming.

Krzysztof Kozlowski <krzk@kernel.org> 於 2025年1月10日 週五 下午5:29寫道:
>
> On 10/01/2025 09:26, Ming Yu wrote:
> > This will allow binding the driver with the device from the device tree.
>
> Rather explain the hardware, because above is not really correct - this
> patch does not allow that.
>
> Anyway:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
index 6e59c8fdef30..4feb76919404 100644
--- a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
+++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
@@ -32,6 +32,9 @@  properties:
       - national,lm89
       - national,lm90
       - national,lm99
+      - nuvoton,nct7716
+      - nuvoton,nct7717
+      - nuvoton,nct7718
       - nxp,sa56004
       - onnn,nct1008
       - ti,tmp451
@@ -120,6 +123,8 @@  allOf:
               - dallas,max6659
               - dallas,max6695
               - dallas,max6696
+              - nuvoton,nct7716
+              - nuvoton,nct7717
     then:
       patternProperties:
         "^channel@([0-2])$":
@@ -155,6 +160,7 @@  allOf:
               - national,lm89
               - national,lm90
               - national,lm99
+              - nuvoton,nct7718
               - nxp,sa56004
               - winbond,w83l771
     then: