ALSA: usb-audio: Add delay quirk for USB Audio Device

Commit Message

胡连勤 Jan. 15, 2025, 6:45 a.m. UTC

From: Lianqin Hu <[e-mail]>

Audio control requests that sets sampling frequency sometimes fail on
this card. Adding delay between control messages eliminates that problem.

Signed-off-by: Lianqin Hu <[e-mail]>
---
 sound/usb/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai Jan. 15, 2025, 8:02 a.m. UTC | #1

On Wed, 15 Jan 2025 07:45:33 +0100,
胡连勤 wrote:
> 
> From: Lianqin Hu <[e-mail]>
> 
> Audio control requests that sets sampling frequency sometimes fail on
> this card. Adding delay between control messages eliminates that problem.
> 
> Signed-off-by: Lianqin Hu <[e-mail]>

Could you give a bit more specific name / model to both the subject
and the quirk comment?  Then it'd be more helpful for people who read
/ check the changes later.


thanks,

Takashi


> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 8ba0aff8be2e..7968d6a2f592 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2239,6 +2239,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */
>  		   QUIRK_FLAG_GET_SAMPLE_RATE),
> +	DEVICE_FLG(0x0d8c, 0x0014, /* USB Audio Device */
> +		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x0ecb, 0x205c, /* JBL Quantum610 Wireless */
>  		   QUIRK_FLAG_FIXED_RATE),
>  	DEVICE_FLG(0x0ecb, 0x2069, /* JBL Quantum810 Wireless */
> -- 
> 2.39.0
>

胡连勤 Jan. 15, 2025, 8:30 a.m. UTC | #2

Hello linux kernel expert:

> On Wed, 15 Jan 2025 07:45:33 +0100,
> 胡连勤 wrote:
> >
> > From: Lianqin Hu <[e-mail]>
> >
> > Audio control requests that sets sampling frequency sometimes fail on
> > this card. Adding delay between control messages eliminates that problem.
> >
> > Signed-off-by: Lianqin Hu <[e-mail]>
> 
> Could you give a bit more specific name / model to both the subject and the
> quirk comment?  Then it'd be more helpful for people who read / check the
> changes later.

We used this sound card to connect to the phone, and only saw the following information in the log, without specific sound card model information:

usb 1-1: New USB device found, idVendor=0d8c, idProduct=0014, bcdDevice= 1.00
usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
usb 1-1: Product: USB Audio Device
usb 1-1: Manufacturer: C-Media Electronics Inc.
usb 1-1: usb_probe_device

We currently do not have an effective way to obtain the detailed model of this sound card. We are very sorry.

Thanks

Takashi Iwai Jan. 15, 2025, 8:41 a.m. UTC | #3

On Wed, 15 Jan 2025 09:30:14 +0100,
胡连勤 wrote:
> 
>  Hello linux kernel expert:
> 
> > On Wed, 15 Jan 2025 07:45:33 +0100,
> > 胡连勤 wrote:
> > >
> > > From: Lianqin Hu <[e-mail]>
> > >
> > > Audio control requests that sets sampling frequency sometimes fail on
> > > this card. Adding delay between control messages eliminates that problem.
> > >
> > > Signed-off-by: Lianqin Hu <[e-mail]>
> > 
> > Could you give a bit more specific name / model to both the subject and the
> > quirk comment?  Then it'd be more helpful for people who read / check the
> > changes later.
> 
> We used this sound card to connect to the phone, and only saw the following information in the log, without specific sound card model information:
> 
> usb 1-1: New USB device found, idVendor=0d8c, idProduct=0014, bcdDevice= 1.00
> usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> usb 1-1: Product: USB Audio Device
> usb 1-1: Manufacturer: C-Media Electronics Inc.
> usb 1-1: usb_probe_device
> 
> We currently do not have an effective way to obtain the detailed model of this sound card. We are very sorry.

Well, you can put such info in the patch description.  It's already
helpful to know whether it's an an unknown / unnamed product.


thanks,

Takashi

胡连勤 Jan. 15, 2025, 8:46 a.m. UTC | #4

Hello linux kernel expert:


> > > >
> > > > From: Lianqin Hu <[e-mail]>
> > > >
> > > > Audio control requests that sets sampling frequency sometimes fail
> > > > on this card. Adding delay between control messages eliminates that
> problem.
> > > >
> > > > Signed-off-by: Lianqin Hu <[e-mail]>
> > >
> > > Could you give a bit more specific name / model to both the subject
> > > and the quirk comment?  Then it'd be more helpful for people who
> > > read / check the changes later.
> >
> > We used this sound card to connect to the phone, and only saw the
> following information in the log, without specific sound card model
> information:
> >
> > usb 1-1: New USB device found, idVendor=0d8c, idProduct=0014,
> > bcdDevice= 1.00 usb 1-1: New USB device strings: Mfr=1, Product=2,
> > SerialNumber=0 usb 1-1: Product: USB Audio Device usb 1-1:
> > Manufacturer: C-Media Electronics Inc.
> > usb 1-1: usb_probe_device
> >
> > We currently do not have an effective way to obtain the detailed model of
> this sound card. We are very sorry.
> 
> Well, you can put such info in the patch description.  It's already helpful to
> know whether it's an an unknown / unnamed product.

OK, I will modify it and send a new patch.

Thanks

Patch

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 8ba0aff8be2e..7968d6a2f592 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2239,6 +2239,8 @@  static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
 	DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */
 		   QUIRK_FLAG_GET_SAMPLE_RATE),
+	DEVICE_FLG(0x0d8c, 0x0014, /* USB Audio Device */
+		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
 	DEVICE_FLG(0x0ecb, 0x205c, /* JBL Quantum610 Wireless */
 		   QUIRK_FLAG_FIXED_RATE),
 	DEVICE_FLG(0x0ecb, 0x2069, /* JBL Quantum810 Wireless */