| Message ID | 20250115064737.16350-1-jason.chien@sifive.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] hw/riscv/riscv-iommu: Remove redundant struct members | expand |
On 15/1/25 07:47, Jason Chien wrote: > Initially, the IOMMU would create a thread, but this thread was removed in > the merged version. The struct members for thread control should have been > removed as well, but they were not removed at that time. ... in commit 0c54acb8243 ("hw/riscv: add RISC-V IOMMU base emulation"). > > Signed-off-by: Jason Chien <jason.chien@sifive.com> > Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > Reviewed-by: Andrew Jones <ajones@ventanamicro.com> > --- > hw/riscv/riscv-iommu.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/hw/riscv/riscv-iommu.h b/hw/riscv/riscv-iommu.h > index 9424989df4..fa8a50fa24 100644 > --- a/hw/riscv/riscv-iommu.h > +++ b/hw/riscv/riscv-iommu.h > @@ -58,11 +58,6 @@ struct RISCVIOMMUState { > /* interrupt notifier */ > void (*notify)(RISCVIOMMUState *iommu, unsigned vector); > > - /* IOMMU State Machine */ > - QemuThread core_proc; /* Background processing thread */ > - QemuCond core_cond; /* Background processing wake up signal */ > - unsigned core_exec; /* Processing thread execution actions */ > - > /* IOMMU target address space */ > AddressSpace *target_as; > MemoryRegion *target_mr;
diff --git a/hw/riscv/riscv-iommu.h b/hw/riscv/riscv-iommu.h index 9424989df4..fa8a50fa24 100644 --- a/hw/riscv/riscv-iommu.h +++ b/hw/riscv/riscv-iommu.h @@ -58,11 +58,6 @@ struct RISCVIOMMUState { /* interrupt notifier */ void (*notify)(RISCVIOMMUState *iommu, unsigned vector); - /* IOMMU State Machine */ - QemuThread core_proc; /* Background processing thread */ - QemuCond core_cond; /* Background processing wake up signal */ - unsigned core_exec; /* Processing thread execution actions */ - /* IOMMU target address space */ AddressSpace *target_as; MemoryRegion *target_mr;