| Message ID | 20250113092608.1349287-1-mripard@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] cgroup/dmem: Select PAGE_COUNTER | expand |
On Mon, Jan 13, 2025 at 10:26:05AM +0100, Maxime Ripard wrote: > The dmem cgroup the page counting API implemented behing the > PAGE_COUNTER kconfig option. However, it doesn't select it, resulting in > potential build breakages. Select PAGE_COUNTER. > > Fixes: b168ed458dde ("kernel/cgroup: Add "dmem" memory accounting cgroup") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202501111330.3VuUx8vf-lkp@intel.com/ > Signed-off-by: Maxime Ripard <mripard@kernel.org> Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> > --- > init/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/init/Kconfig b/init/Kconfig > index 61f50cafa815..5e5328506138 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1137,10 +1137,11 @@ config CGROUP_RDMA > Attaching processes with active RDMA resources to the cgroup > hierarchy is allowed even if can cross the hierarchy's limit. > > config CGROUP_DMEM > bool "Device memory controller (DMEM)" > + select PAGE_COUNTER > help > The DMEM controller allows compatible devices to restrict device > memory usage based on the cgroup hierarchy. > > As an example, it allows you to restrict VRAM usage for applications > -- > 2.47.1 >
On Tue, Jan 14, 2025 at 03:53:23PM +0100, Simona Vetter wrote: > On Mon, Jan 13, 2025 at 10:26:05AM +0100, Maxime Ripard wrote: > > The dmem cgroup the page counting API implemented behing the > > PAGE_COUNTER kconfig option. However, it doesn't select it, resulting in > > potential build breakages. Select PAGE_COUNTER. > > > > Fixes: b168ed458dde ("kernel/cgroup: Add "dmem" memory accounting cgroup") > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202501111330.3VuUx8vf-lkp@intel.com/ > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> These patches have been pulled as a separate PR into drm-next, and I'm not sure how we should merge these patches. Obviously, we'd need Tejun's, Johannes', or Michal's ack, but should we backmerged drm-next into drm-misc-next-fixes and apply them there? Maxime
On Tue, Jan 14, 2025 at 04:02:55PM +0100, Maxime Ripard wrote: > On Tue, Jan 14, 2025 at 03:53:23PM +0100, Simona Vetter wrote: > > On Mon, Jan 13, 2025 at 10:26:05AM +0100, Maxime Ripard wrote: > > > The dmem cgroup the page counting API implemented behing the > > > PAGE_COUNTER kconfig option. However, it doesn't select it, resulting in > > > potential build breakages. Select PAGE_COUNTER. > > > > > > Fixes: b168ed458dde ("kernel/cgroup: Add "dmem" memory accounting cgroup") > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202501111330.3VuUx8vf-lkp@intel.com/ > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > > > Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> > > These patches have been pulled as a separate PR into drm-next, and I'm > not sure how we should merge these patches. > > Obviously, we'd need Tejun's, Johannes', or Michal's ack, but should we > backmerged drm-next into drm-misc-next-fixes and apply them there? Acked-by: Tejun Heo <tj@kernel.org> Please route them with the existing dmem patches. Thanks.
On Mon, 13 Jan 2025 10:26:05 +0100, Maxime Ripard wrote: > The dmem cgroup the page counting API implemented behing the > PAGE_COUNTER kconfig option. However, it doesn't select it, resulting in > potential build breakages. Select PAGE_COUNTER. > > Applied to misc/kernel.git (drm-misc-next-fixes). Thanks! Maxime
diff --git a/init/Kconfig b/init/Kconfig index 61f50cafa815..5e5328506138 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1137,10 +1137,11 @@ config CGROUP_RDMA Attaching processes with active RDMA resources to the cgroup hierarchy is allowed even if can cross the hierarchy's limit. config CGROUP_DMEM bool "Device memory controller (DMEM)" + select PAGE_COUNTER help The DMEM controller allows compatible devices to restrict device memory usage based on the cgroup hierarchy. As an example, it allows you to restrict VRAM usage for applications
The dmem cgroup the page counting API implemented behing the PAGE_COUNTER kconfig option. However, it doesn't select it, resulting in potential build breakages. Select PAGE_COUNTER. Fixes: b168ed458dde ("kernel/cgroup: Add "dmem" memory accounting cgroup") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501111330.3VuUx8vf-lkp@intel.com/ Signed-off-by: Maxime Ripard <mripard@kernel.org> --- init/Kconfig | 1 + 1 file changed, 1 insertion(+)