| Message ID | 7da6ac56-af55-4436-9597-6af24df8122c@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] PCI: rockchip: Clean up on error in rockchip_pcie_init_port() | expand |
Hello, > Call phy_exit() before returning on this error path. > > Fixes: 853c711e2caf ("PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function") I squashed this together with the code this fixes. Thank you a bunch! Krzysztof
diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c index fea867c24f75..35bfdf3e17a3 100644 --- a/drivers/pci/controller/pcie-rockchip.c +++ b/drivers/pci/controller/pcie-rockchip.c @@ -132,8 +132,10 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip) err = reset_control_bulk_assert(ROCKCHIP_NUM_CORE_RSTS, rockchip->core_rsts); - if (err) - return dev_err_probe(dev, err, "Couldn't assert Core resets\n"); + if (err) { + dev_err_probe(dev, err, "Couldn't assert Core resets\n"); + goto err_exit_phy; + } udelay(10);
Call phy_exit() before returning on this error path. Fixes: 853c711e2caf ("PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/pci/controller/pcie-rockchip.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)