| Message ID | 20250114220147.757075-4-ninad@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | DTS updates for system1 BMC | expand |
On Tue, 14 Jan 2025 16:01:37 -0600, Ninad Palsule wrote: > Allow parsing GPIO controller children nodes with GPIO hogs. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250114220147.757075-4-ninad@linux.ibm.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote: > Allow parsing GPIO controller children nodes with GPIO hogs. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > index b9afd07a9d24..b9bc4fe4d5a6 100644 > --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > @@ -46,6 +46,12 @@ properties: > minimum: 12 > maximum: 232 > > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": Choose one - suffix or prefix. More popular is suffix. Best regards, Krzysztof
On Wed, Jan 15, 2025 at 09:45:50AM +0100, Krzysztof Kozlowski wrote: > On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote: > > Allow parsing GPIO controller children nodes with GPIO hogs. > > > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > > --- > > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > index b9afd07a9d24..b9bc4fe4d5a6 100644 > > --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > @@ -46,6 +46,12 @@ properties: > > minimum: 12 > > maximum: 232 > > > > +patternProperties: > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > Choose one - suffix or prefix. More popular is suffix. I was about to say that, but this matches what gpio-hog.yaml defines. Why we did both, I don't remember. We could probably eliminate 'hog-[0-9]+' as that doesn't appear to be used much. Long term, I want to make all gpio controllers reference a gpio controller schema and put the hog stuff there. Then we have the node names defined in 1 place. Rob
diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml index b9afd07a9d24..b9bc4fe4d5a6 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml @@ -46,6 +46,12 @@ properties: minimum: 12 maximum: 232 +patternProperties: + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": + type: object + required: + - gpio-hog + required: - compatible - reg
Allow parsing GPIO controller children nodes with GPIO hogs. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ 1 file changed, 6 insertions(+)