| Message ID | 20250115103858.104709-4-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add support for RZ/G3E WDT | expand |
On 1/15/25 02:38, Biju Das wrote: > RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. > Add Kconfig dependency for RZV2HWDT driver with ARCH_R9A09G47 and > update the help description. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> The subject is a bit misleading. It would be better named "Enable the RZV2HWDT driver for ARCH_R9A09G47" or similar. Guenter > --- > drivers/watchdog/Kconfig | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index f81705f8539a..646a84cc03e3 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -963,13 +963,14 @@ config RENESAS_RZG2LWDT > Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system. > > config RENESAS_RZV2HWDT > - tristate "Renesas RZ/V2H(P) WDT Watchdog" > - depends on ARCH_R9A09G057 || COMPILE_TEST > + tristate "Renesas RZ/{G3E,V2H(P)} WDT Watchdog" > + depends on ARCH_R9A09G047 || ARCH_R9A09G057 || COMPILE_TEST > depends on PM || COMPILE_TEST > select WATCHDOG_CORE > help > This driver adds watchdog support for the integrated watchdogs in the > - Renesas RZ/V2H(P) SoCs. These watchdogs can be used to reset a system. > + Renesas RZ/{G3E,V2H(P)} SoCs. These watchdogs can be used to reset a > + system. > > config ASPEED_WATCHDOG > tristate "Aspeed BMC watchdog support"
Hi Guenter, Thanks for the feedback. > -----Original Message----- > From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck > Sent: 15 January 2025 14:55 > Subject: Re: [PATCH 3/5] watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47 > > On 1/15/25 02:38, Biju Das wrote: > > RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. > > Add Kconfig dependency for RZV2HWDT driver with ARCH_R9A09G47 and > > update the help description. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > The subject is a bit misleading. It would be better named "Enable the RZV2HWDT driver for > ARCH_R9A09G47" or similar. OK, Will update subject and description. Cheers, Biju
On Wed, Jan 15, 2025 at 10:38:52AM +0000, Biju Das wrote: > RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. > Add Kconfig dependency for RZV2HWDT driver with ARCH_R9A09G47 and > update the help description. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > drivers/watchdog/Kconfig | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index f81705f8539a..646a84cc03e3 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -963,13 +963,14 @@ config RENESAS_RZG2LWDT > Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system. > > config RENESAS_RZV2HWDT > - tristate "Renesas RZ/V2H(P) WDT Watchdog" > - depends on ARCH_R9A09G057 || COMPILE_TEST > + tristate "Renesas RZ/{G3E,V2H(P)} WDT Watchdog" This is close to churn... > + depends on ARCH_R9A09G047 || ARCH_R9A09G057 || COMPILE_TEST But this is just wrong. You are supposed to depend on renesas ARHC, not your individual SoC (and this is what you called here "ARCH_R9A..."). Greg many times gave strong opinion that even full ARCH is wrong and we managed to convince him that it has a meaning (or he did not want to keep discussing). But restricting it per soc is pointless and impossible to defend in discussion. Best regards, Krzysztof
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index f81705f8539a..646a84cc03e3 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -963,13 +963,14 @@ config RENESAS_RZG2LWDT Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system. config RENESAS_RZV2HWDT - tristate "Renesas RZ/V2H(P) WDT Watchdog" - depends on ARCH_R9A09G057 || COMPILE_TEST + tristate "Renesas RZ/{G3E,V2H(P)} WDT Watchdog" + depends on ARCH_R9A09G047 || ARCH_R9A09G057 || COMPILE_TEST depends on PM || COMPILE_TEST select WATCHDOG_CORE help This driver adds watchdog support for the integrated watchdogs in the - Renesas RZ/V2H(P) SoCs. These watchdogs can be used to reset a system. + Renesas RZ/{G3E,V2H(P)} SoCs. These watchdogs can be used to reset a + system. config ASPEED_WATCHDOG tristate "Aspeed BMC watchdog support"
RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. Add Kconfig dependency for RZV2HWDT driver with ARCH_R9A09G47 and update the help description. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/watchdog/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)