| Message ID | 20250116230427.17740-1-xose.vazquez@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Benjamin Marzinski |
| Headers | show |
| Series | multipath-tools: Merge Infinidat with Lenovo in hwtable | expand |
On Fri, 2025-01-17 at 00:04 +0100, Xose Vazquez Perez wrote: > Lenovo to acquire Infinidat: > https://www.infinidat.com/en/news/press-releases/lenovo-acquire-infinidat-further-expanding-enterprise-storage-portfolio > Does our hwtable have to reflect company acquisitions? Martin
On 1/17/25 2:54 PM, Martin Wilck wrote: > On Fri, 2025-01-17 at 00:04 +0100, Xose Vazquez Perez wrote: >> Lenovo to acquire Infinidat: >> https://www.infinidat.com/en/news/press-releases/lenovo-acquire-infinidat-further-expanding-enterprise-storage-portfolio >> > > Does our hwtable have to reflect company acquisitions? Not directly, but it's order by vendors. So..
Hello Xose, On Fri, 2025-01-17 at 15:16 +0100, Xose Vazquez Perez wrote: > On 1/17/25 2:54 PM, Martin Wilck wrote: > > > On Fri, 2025-01-17 at 00:04 +0100, Xose Vazquez Perez wrote: > > > Lenovo to acquire Infinidat: > > > https://www.infinidat.com/en/news/press-releases/lenovo-acquire-infinidat-further-expanding-enterprise-storage-portfolio > > > > > > > Does our hwtable have to reflect company acquisitions? > > Not directly, but it's order by vendors. So.. If device names change, any time. But just because vendor A has bought vendor B, I don't think a code change is warranted. This kind of change makes `git blame` more cumbersome to use, with almost no benefit. The sort order in hwtable.c is not guaranteed in any way. Users who are interested in the defaults for a given device will search for the vendor and/or device name anyway. Regards Martin
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 543f0bc1..2c26b42a 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -788,6 +788,24 @@ static struct hwentry default_hw[] = { .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 30, }, + { + /* + * Infinidat InfiniBox + * + * Maintainer: Arnon Yaari <arnony@infinidat.com> + */ + .vendor = "NFINIDAT", + .product = "InfiniBox", + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = 30, + .prio_name = PRIO_ALUA, + .selector = "round-robin 0", + .rr_weight = RR_WEIGHT_PRIO, + .no_path_retry = NO_PATH_RETRY_FAIL, + .minio = 1, + .minio_rq = 1, + .fast_io_fail = 15, + }, /* * NetApp */ @@ -1121,25 +1139,6 @@ static struct hwentry default_hw[] = { .product = "XPD", .pgpolicy = MULTIBUS, }, - /* - * Infinidat - * - * Maintainer: Arnon Yaari <arnony@infinidat.com> - */ - { - /* InfiniBox */ - .vendor = "NFINIDAT", - .product = "InfiniBox", - .pgpolicy = GROUP_BY_PRIO, - .pgfailback = 30, - .prio_name = PRIO_ALUA, - .selector = "round-robin 0", - .rr_weight = RR_WEIGHT_PRIO, - .no_path_retry = NO_PATH_RETRY_FAIL, - .minio = 1, - .minio_rq = 1, - .fast_io_fail = 15, - }, /* * Kaminario */
Lenovo to acquire Infinidat: https://www.infinidat.com/en/news/press-releases/lenovo-acquire-infinidat-further-expanding-enterprise-storage-portfolio Cc: Martin Wilck <mwilck@suse.com> Cc: Benjamin Marzinski <bmarzins@redhat.com> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: DM-DEVEL ML <dm-devel@lists.linux.dev> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- libmultipath/hwtable.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-)