| Message ID | 20250117112228.90948-1-anezbeda@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: macsec: Add endianness annotations in salt struct | expand |
On Fri, Jan 17, 2025 at 12:22:28PM +0100, Ales Nezbeda wrote: > This change resolves warning produced by sparse tool as currently > there is a mismatch between normal generic type in salt and endian > annotated type in macsec driver code. Endian annotated types should > be used here. > > Sparse output: > warning: restricted ssci_t degrades to integer > warning: incorrect type in assignment (different base types) > expected restricted ssci_t [usertype] ssci > got unsigned int > warning: restricted __be64 degrades to integer > warning: incorrect type in assignment (different base types) > expected restricted __be64 [usertype] pn > got unsigned long long > > Signed-off-by: Ales Nezbeda <anezbeda@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/include/net/macsec.h b/include/net/macsec.h index de216cbc6b05..bc7de5b53e54 100644 --- a/include/net/macsec.h +++ b/include/net/macsec.h @@ -38,8 +38,8 @@ struct metadata_dst; typedef union salt { struct { - u32 ssci; - u64 pn; + ssci_t ssci; + __be64 pn; } __packed; u8 bytes[MACSEC_SALT_LEN]; } __packed salt_t;
This change resolves warning produced by sparse tool as currently there is a mismatch between normal generic type in salt and endian annotated type in macsec driver code. Endian annotated types should be used here. Sparse output: warning: restricted ssci_t degrades to integer warning: incorrect type in assignment (different base types) expected restricted ssci_t [usertype] ssci got unsigned int warning: restricted __be64 degrades to integer warning: incorrect type in assignment (different base types) expected restricted __be64 [usertype] pn got unsigned long long Signed-off-by: Ales Nezbeda <anezbeda@redhat.com> --- include/net/macsec.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)