| Message ID | 20250116232954.2696930-1-sean.anderson@linux.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM | expand |
On Thu, 16 Jan 2025 18:29:48 -0500 Sean Anderson wrote:
> - Fix incorrect function name in doc comment for axienet_coalesce_params
Huh, I wonder if you sent the wrong version..
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 16 Jan 2025 18:29:48 -0500 you wrote: > To improve performance without sacrificing latency under low load, > enable DIM. While I appreciate not having to write the library myself, I > do think there are many unusual aspects to DIM, as detailed in the last > patch. > > Changes in v4: > - Fix incorrect function name in doc comment for axienet_coalesce_params > - Rebase onto net-next/master > > [...] Here is the summary with links: - [net-next,v4,1/6] net: xilinx: axienet: Add some symbolic constants for IRQ delay timer https://git.kernel.org/netdev/net-next/c/5cff9d1756fb - [net-next,v4,2/6] net: xilinx: axienet: Report an error for bad coalesce settings https://git.kernel.org/netdev/net-next/c/9d301a53a532 - [net-next,v4,3/6] net: xilinx: axienet: Combine CR calculation (no matching commit) - [net-next,v4,4/6] net: xilinx: axienet: Support adjusting coalesce settings while running (no matching commit) - [net-next,v4,5/6] net: xilinx: axienet: Get coalesce parameters from driver state (no matching commit) - [net-next,v4,6/6] net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM (no matching commit) You are awesome, thank you!
On 1/18/25 20:19, Jakub Kicinski wrote: > On Thu, 16 Jan 2025 18:29:48 -0500 Sean Anderson wrote: >> - Fix incorrect function name in doc comment for axienet_coalesce_params > > Huh, I wonder if you sent the wrong version.. I think I applied the hunk to the wrong patch. --Sean
To improve performance without sacrificing latency under low load, enable DIM. While I appreciate not having to write the library myself, I do think there are many unusual aspects to DIM, as detailed in the last patch. Changes in v4: - Fix incorrect function name in doc comment for axienet_coalesce_params - Rebase onto net-next/master Changes in v3: - Fix mismatched parameter name documentation for axienet_calc_cr - Integrate some cleanups originally included in https://lore.kernel.org/netdev/20240909230908.1319982-1-sean.anderson@linux.dev/ - Move spin (un)locking in IRQs inside the if condition of napi_schedule_prep. This lets us hold the lock just for the rmw. - Fix function name in doc comments for axienet_update_coalesce_rx/tx - Adjust axienet_local doc comment order to match the members - Rebase onto net-next/master Changes in v2: - Add some symbolic constants for IRQ delay timer - Report an error for bad coalesce settings - Don't use spin_lock_irqsave when we know the context - Split the CR calculation refactor from runtime coalesce settings adjustment support for easier review. - Have axienet_update_coalesce_rx/tx take the cr value/mask instead of calculating it with axienet_calc_cr. This will make it easier to add partial updates in the next few commits. - Get coalesce parameters from driver state - Don't take the RTNL in axienet_rx_dim_work to avoid deadlock. Instead, calculate a partial cr update that axienet_update_coalesce_rx can perform under a spin lock. - Use READ/WRITE_ONCE when accessing/modifying rx_irqs Sean Anderson (6): net: xilinx: axienet: Add some symbolic constants for IRQ delay timer net: xilinx: axienet: Report an error for bad coalesce settings net: xilinx: axienet: Combine CR calculation net: xilinx: axienet: Support adjusting coalesce settings while running net: xilinx: axienet: Get coalesce parameters from driver state net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM drivers/net/ethernet/xilinx/Kconfig | 1 + drivers/net/ethernet/xilinx/xilinx_axienet.h | 32 +- .../net/ethernet/xilinx/xilinx_axienet_main.c | 330 ++++++++++++++---- 3 files changed, 280 insertions(+), 83 deletions(-)