| Message ID | 20250117-qcom-ice-fix-dev-leak-v2-4-1ffa5b6884cb@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | soc: qcom: ice: fix dev reference leaked through of_qcom_ice_get | expand |
On 25-01-17 14:18:53, Tudor Ambarus wrote: > There's no consumer calling it left, make the method static. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/soc/qcom/ice.c | 3 +-- > include/soc/qcom/ice.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index 79e04bff3e33..2310afa77b76 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -262,7 +262,7 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > * Return: ICE pointer on success, NULL if there is no ICE data provided by the > * consumer or ERR_PTR() on error. > */ > -struct qcom_ice *of_qcom_ice_get(struct device *dev) > +static struct qcom_ice *of_qcom_ice_get(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct qcom_ice *ice; > @@ -323,7 +323,6 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) > > return ice; > } > -EXPORT_SYMBOL_GPL(of_qcom_ice_get); > > static void qcom_ice_put(const struct qcom_ice *ice) > { > diff --git a/include/soc/qcom/ice.h b/include/soc/qcom/ice.h > index d5f6a228df65..fdf1b5c21eb9 100644 > --- a/include/soc/qcom/ice.h > +++ b/include/soc/qcom/ice.h > @@ -33,7 +33,6 @@ int qcom_ice_program_key(struct qcom_ice *ice, > const u8 crypto_key[], u8 data_unit_size, > int slot); > int qcom_ice_evict_key(struct qcom_ice *ice, int slot); > -struct qcom_ice *of_qcom_ice_get(struct device *dev); > struct qcom_ice *devm_of_qcom_ice_get(struct device *dev); > > #endif /* __QCOM_ICE_H__ */ > > -- > 2.48.0.rc2.279.g1de40edade-goog >
diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index 79e04bff3e33..2310afa77b76 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -262,7 +262,7 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, * Return: ICE pointer on success, NULL if there is no ICE data provided by the * consumer or ERR_PTR() on error. */ -struct qcom_ice *of_qcom_ice_get(struct device *dev) +static struct qcom_ice *of_qcom_ice_get(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct qcom_ice *ice; @@ -323,7 +323,6 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) return ice; } -EXPORT_SYMBOL_GPL(of_qcom_ice_get); static void qcom_ice_put(const struct qcom_ice *ice) { diff --git a/include/soc/qcom/ice.h b/include/soc/qcom/ice.h index d5f6a228df65..fdf1b5c21eb9 100644 --- a/include/soc/qcom/ice.h +++ b/include/soc/qcom/ice.h @@ -33,7 +33,6 @@ int qcom_ice_program_key(struct qcom_ice *ice, const u8 crypto_key[], u8 data_unit_size, int slot); int qcom_ice_evict_key(struct qcom_ice *ice, int slot); -struct qcom_ice *of_qcom_ice_get(struct device *dev); struct qcom_ice *devm_of_qcom_ice_get(struct device *dev); #endif /* __QCOM_ICE_H__ */