| Message ID | 20250119183424.259353-3-sander@svanheule.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mips: dts: Split Realtek devicetrees | expand |
Hi Sander, On 20/01/2025 07:34, Sander Vanheule wrote: > The referenced CPU clock does not require any additional #clock-cells, > so drop the extraneous '0' in the referenced CPU clock. > > The binding for MIPS cpus also does not allow for the clock-names > property, so just drop it. > > This resolves some error message from 'dtbs_check': > cpu@0: clocks: [[4], [0]] is too long > 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Sander Vanheule <sander@svanheule.net> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Tested-by: Chris Packham <chris.packham@alliedtelesis.co.nz> # For RTL9302C > --- > arch/mips/boot/dts/realtek/rtl838x.dtsi | 3 +-- > arch/mips/boot/dts/realtek/rtl930x.dtsi | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/mips/boot/dts/realtek/rtl838x.dtsi b/arch/mips/boot/dts/realtek/rtl838x.dtsi > index 722106e39194..d2c6baabb38c 100644 > --- a/arch/mips/boot/dts/realtek/rtl838x.dtsi > +++ b/arch/mips/boot/dts/realtek/rtl838x.dtsi > @@ -9,8 +9,7 @@ cpu@0 { > device_type = "cpu"; > compatible = "mips,mips4KEc"; > reg = <0>; > - clocks = <&baseclk 0>; > - clock-names = "cpu"; > + clocks = <&baseclk>; > }; > }; > > diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/realtek/rtl930x.dtsi > index 67261d6fcaa7..f2e57ea3a60c 100644 > --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi > +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi > @@ -26,8 +26,7 @@ cpu@0 { > device_type = "cpu"; > compatible = "mips,mips34Kc"; > reg = <0>; > - clocks = <&baseclk 0>; > - clock-names = "cpu"; > + clocks = <&baseclk>; > }; > }; >
diff --git a/arch/mips/boot/dts/realtek/rtl838x.dtsi b/arch/mips/boot/dts/realtek/rtl838x.dtsi index 722106e39194..d2c6baabb38c 100644 --- a/arch/mips/boot/dts/realtek/rtl838x.dtsi +++ b/arch/mips/boot/dts/realtek/rtl838x.dtsi @@ -9,8 +9,7 @@ cpu@0 { device_type = "cpu"; compatible = "mips,mips4KEc"; reg = <0>; - clocks = <&baseclk 0>; - clock-names = "cpu"; + clocks = <&baseclk>; }; }; diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/realtek/rtl930x.dtsi index 67261d6fcaa7..f2e57ea3a60c 100644 --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi @@ -26,8 +26,7 @@ cpu@0 { device_type = "cpu"; compatible = "mips,mips34Kc"; reg = <0>; - clocks = <&baseclk 0>; - clock-names = "cpu"; + clocks = <&baseclk>; }; };
The referenced CPU clock does not require any additional #clock-cells, so drop the extraneous '0' in the referenced CPU clock. The binding for MIPS cpus also does not allow for the clock-names property, so just drop it. This resolves some error message from 'dtbs_check': cpu@0: clocks: [[4], [0]] is too long 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Sander Vanheule <sander@svanheule.net> --- arch/mips/boot/dts/realtek/rtl838x.dtsi | 3 +-- arch/mips/boot/dts/realtek/rtl930x.dtsi | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)