| Message ID | 20250117220955.2482817-1-jaegeuk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e02938613eb206ebf788e2d3d4fccf534e4ea12e |
| Headers | show |
| Series | [f2fs-dev] f2fs: avoid trying to get invalid block address | expand |
On 1/18/25 06:09, Jaegeuk Kim via Linux-f2fs-devel wrote: > In f2fs_new_inode(), if we fail to get a new inode, we go iput(), followed by > f2fs_evict_inode(). If the inode is not marked as bad, it'll try to call > f2fs_remove_inode_page() which tries to read the inode block given node id. > But, there's no block address allocated yet, which gives a chance to access > a wrong block address, if the block device has some garbage data in NAT table. > > We need to make sure NAT table should have zero data for all the unallocated > node ids, but also would be better to take this unnecessary path as well. > Let's mark the faild inode as bad. > Needs a fixes line? Fixes: 0abd675e97e6 ("f2fs: support plain user/group quota") Otherwise, it looks good to me. Reviewed-by: Chao Yu <chao@kernel.org> Thanks, > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/namei.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c > index 57d46e1439de..a278c7da8177 100644 > --- a/fs/f2fs/namei.c > +++ b/fs/f2fs/namei.c > @@ -341,6 +341,7 @@ static struct inode *f2fs_new_inode(struct mnt_idmap *idmap, > trace_f2fs_new_inode(inode, err); > dquot_drop(inode); > inode->i_flags |= S_NOQUOTA; > + make_bad_inode(inode); > if (nid_free) > set_inode_flag(inode, FI_FREE_NID); > clear_nlink(inode);
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Fri, 17 Jan 2025 22:09:55 +0000 you wrote: > In f2fs_new_inode(), if we fail to get a new inode, we go iput(), followed by > f2fs_evict_inode(). If the inode is not marked as bad, it'll try to call > f2fs_remove_inode_page() which tries to read the inode block given node id. > But, there's no block address allocated yet, which gives a chance to access > a wrong block address, if the block device has some garbage data in NAT table. > > We need to make sure NAT table should have zero data for all the unallocated > node ids, but also would be better to take this unnecessary path as well. > Let's mark the faild inode as bad. > > [...] Here is the summary with links: - [f2fs-dev] f2fs: avoid trying to get invalid block address https://git.kernel.org/jaegeuk/f2fs/c/e02938613eb2 You are awesome, thank you!
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 57d46e1439de..a278c7da8177 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -341,6 +341,7 @@ static struct inode *f2fs_new_inode(struct mnt_idmap *idmap, trace_f2fs_new_inode(inode, err); dquot_drop(inode); inode->i_flags |= S_NOQUOTA; + make_bad_inode(inode); if (nid_free) set_inode_flag(inode, FI_FREE_NID); clear_nlink(inode);
In f2fs_new_inode(), if we fail to get a new inode, we go iput(), followed by f2fs_evict_inode(). If the inode is not marked as bad, it'll try to call f2fs_remove_inode_page() which tries to read the inode block given node id. But, there's no block address allocated yet, which gives a chance to access a wrong block address, if the block device has some garbage data in NAT table. We need to make sure NAT table should have zero data for all the unallocated node ids, but also would be better to take this unnecessary path as well. Let's mark the faild inode as bad. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/namei.c | 1 + 1 file changed, 1 insertion(+)