| Message ID | 20250119085357.17735-1-tiwai@suse.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: usb: fcp: Fix hwdep read ops argument | expand |
On Sun, 19 Jan 2025 09:53:28 +0100, Takashi Iwai wrote: > > The hwdep read ops argument is long instead of ssize_t due to > historical reason. Fix the build error. > > Fixes: 46757a3e7d50 ("ALSA: FCP: Add Focusrite Control Protocol driver") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202501190536.A2CiOP0a-lkp@intel.com/ > Signed-off-by: Takashi Iwai <tiwai@suse.de> > --- > sound/usb/fcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/fcp.c b/sound/usb/fcp.c > index 655e4f7338ed..eb6a5c1f9b21 100644 > --- a/sound/usb/fcp.c > +++ b/sound/usb/fcp.c > @@ -816,7 +816,7 @@ static int fcp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, > } > > static ssize_t fcp_hwdep_read(struct snd_hwdep *hw, char __user *buf, > - ssize_t count, loff_t *offset) > + long count, loff_t *offset) > { > struct usb_mixer_interface *mixer = hw->private_data; > struct fcp_data *private = mixer->private_data; Gah, that wasn't enough, a few other ssize_t had to be replaced with long. Stephen already submitted the fix patch for linux-next, and I'll take it instead. Takashi
diff --git a/sound/usb/fcp.c b/sound/usb/fcp.c index 655e4f7338ed..eb6a5c1f9b21 100644 --- a/sound/usb/fcp.c +++ b/sound/usb/fcp.c @@ -816,7 +816,7 @@ static int fcp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, } static ssize_t fcp_hwdep_read(struct snd_hwdep *hw, char __user *buf, - ssize_t count, loff_t *offset) + long count, loff_t *offset) { struct usb_mixer_interface *mixer = hw->private_data; struct fcp_data *private = mixer->private_data;
The hwdep read ops argument is long instead of ssize_t due to historical reason. Fix the build error. Fixes: 46757a3e7d50 ("ALSA: FCP: Add Focusrite Control Protocol driver") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501190536.A2CiOP0a-lkp@intel.com/ Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/usb/fcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)