| Message ID | 20250120172111.3492708-8-m.wilczynski@samsung.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [RFC,v3,01/18] dt-bindings: clock: Add VO subsystem clock controller support | expand |
On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: > Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This > controller manages resets for subsystems such as the GPU within the > TH1520 SoC. This mentions "resets", plural, but the #reset-cells = <0> below and the driver implementation look like there only is a single reset control (for the GPU). > > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> > --- > .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > new file mode 100644 > index 000000000000..c15a80e00935 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD TH1520 SoC Reset Controller > + > +description: > + The T-HEAD TH1520 reset controller is a hardware block that asserts/deasserts > + resets for SoC subsystems. Again, plural. > + > +maintainers: > + - Michal Wilczynski <m.wilczynski@samsung.com> > + > +properties: > + compatible: > + enum: > + - thead,th1520-reset > + > + reg: > + maxItems: 1 > + > + "#reset-cells": > + const: 0 Should this be "const: 1" instead? regards Philipp
On 1/21/25 09:35, Philipp Zabel wrote: > On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: >> Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This >> controller manages resets for subsystems such as the GPU within the >> TH1520 SoC. > > This mentions "resets", plural, but the #reset-cells = <0> below and > the driver implementation look like there only is a single reset > control (for the GPU). > >> >> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> >> --- >> .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 45 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml >> >> diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml >> new file mode 100644 >> index 000000000000..c15a80e00935 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml >> @@ -0,0 +1,44 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://protect2.fireeye.com/v1/url?k=9a1e91c0-fb9584d9-9a1f1a8f-74fe485cbfec-4ac5a7f48f7ed305&q=1&e=57e2ad34-940c-48d4-b365-a5719457bd20&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Freset%2Fthead%2Cth1520-reset.yaml%23 >> +$schema: https://protect2.fireeye.com/v1/url?k=40dd1447-2156015e-40dc9f08-74fe485cbfec-5ae5fe2734d49263&q=1&e=57e2ad34-940c-48d4-b365-a5719457bd20&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: T-HEAD TH1520 SoC Reset Controller >> + >> +description: >> + The T-HEAD TH1520 reset controller is a hardware block that asserts/deasserts >> + resets for SoC subsystems. > > Again, plural. Yeah should be singular sorry. > >> + >> +maintainers: >> + - Michal Wilczynski <m.wilczynski@samsung.com> >> + >> +properties: >> + compatible: >> + enum: >> + - thead,th1520-reset >> + >> + reg: >> + maxItems: 1 >> + >> + "#reset-cells": >> + const: 0 > > Should this be "const: 1" instead? Right now I'm not planning to extend by more resets, I've thought about this during the discussion on v2 of this patchset. At this point I just can't see more interesting resets to have. Vendor kernel implements WDT and NPU. I don't think NPU driver will be upstream anytime soon. That would leave WDT reset potentially. > > regards > Philipp > >
On 21/01/2025 22:58, Michal Wilczynski wrote: >>> +maintainers: >>> + - Michal Wilczynski <m.wilczynski@samsung.com> >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - thead,th1520-reset >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + "#reset-cells": >>> + const: 0 >> >> Should this be "const: 1" instead? > > Right now I'm not planning to extend by more resets, I've thought about > this during the discussion on v2 of this patchset. At this point I just > can't see more interesting resets to have. Vendor kernel implements WDT > and NPU. I don't think NPU driver will be upstream anytime soon. That > would leave WDT reset potentially. Bindings should be complete, regardless whether you implement reset consumer driver or not. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml new file mode 100644 index 000000000000..c15a80e00935 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: T-HEAD TH1520 SoC Reset Controller + +description: + The T-HEAD TH1520 reset controller is a hardware block that asserts/deasserts + resets for SoC subsystems. + +maintainers: + - Michal Wilczynski <m.wilczynski@samsung.com> + +properties: + compatible: + enum: + - thead,th1520-reset + + reg: + maxItems: 1 + + "#reset-cells": + const: 0 + +required: + - compatible + - reg + - "#reset-cells" + +additionalProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + rst: reset-controller@ffef528000 { + compatible = "thead,th1520-reset"; + reg = <0xff 0xef528000 0x0 0x1000>; + #reset-cells = <0>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 363bb3471a33..1b6e894500ef 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20189,6 +20189,7 @@ F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml F: Documentation/devicetree/bindings/pinctrl/thead,th1520-pinctrl.yaml +F: Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml F: arch/riscv/boot/dts/thead/ F: drivers/clk/thead/clk-th1520-ap.c F: drivers/firmware/thead,th1520-aon.c
Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This controller manages resets for subsystems such as the GPU within the TH1520 SoC. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml