| Message ID | 20250121074017.2819285-6-joy.zou@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add i.MX91 platform support | expand |
On 21/01/2025 08:40, Joy Zou wrote: > Making the references easier, so add labels. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx93.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi > index 56766fdb0b1e..4739e7cb7e9b 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -206,7 +206,7 @@ cpu_crit: cpu-crit { > }; > > cooling-maps { > - map0 { > + map0: map0 { > trip = <&cpu_alert>; > cooling-device = > <&A55_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > @@ -1334,7 +1334,7 @@ usbmisc2: usbmisc@4c200200 { > #index-cells = <1>; > }; > > - ddr-pmu@4e300dc0 { > + ddr_pmu: ddr-pmu@4e300dc0 { Useless commit - there are no users. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2025年1月21日 15:49 > To: Joy Zou <joy.zou@nxp.com>; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > catalin.marinas@arm.com; will@kernel.org; kernel@pengutronix.de; > festevam@gmail.com > Cc: joao.goncalves@toradex.com; marex@denx.de; > hvilleneuve@dimonoff.com; hiago.franco@toradex.com; Peng Fan > <peng.fan@nxp.com>; frieder.schrempf@kontron.de; > alexander.stein@ew.tq-group.com; m.othacehe@gmail.com; > mwalle@kernel.org; Max.Merchel@ew.tq-group.com; > quic_bjorande@quicinc.com; geert+renesas@glider.be; > dmitry.baryshkov@linaro.org; neil.armstrong@linaro.org; arnd@arndb.de; > nfraprado@collabora.com; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org; Jacky Bai <ping.bai@nxp.com>; Ye Li > <ye.li@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; Frank Li > <frank.li@nxp.com>; Carlos Song <carlos.song@nxp.com> > Subject: [EXT] Re: [PATCH v4 5/5] arm64: dts: imx93: Add labels for the > references easier > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 21/01/2025 08:40, Joy Zou wrote: > > Making the references easier, so add labels. > > > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx93.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > b/arch/arm64/boot/dts/freescale/imx93.dtsi > > index 56766fdb0b1e..4739e7cb7e9b 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > @@ -206,7 +206,7 @@ cpu_crit: cpu-crit { > > }; > > > > cooling-maps { > > - map0 { > > + map0: map0 { > > trip = <&cpu_alert>; > > cooling-device = > > <&A55_0 > THERMAL_NO_LIMIT > > THERMAL_NO_LIMIT>, @@ -1334,7 +1334,7 @@ usbmisc2: > usbmisc@4c200200 { > > #index-cells = <1>; > > }; > > > > - ddr-pmu@4e300dc0 { > > + ddr_pmu: ddr-pmu@4e300dc0 { > > Useless commit - there are no users. Thanks for your comments! Have used the labels in imx91.dtsi. The imx91.dtsi have included the imx93.dtsi. BR Joy Zou > > Best regards, > Krzysztof
On Tue, Jan 21, 2025 at 08:25:51AM +0000, Joy Zou wrote: > > THERMAL_NO_LIMIT > > > THERMAL_NO_LIMIT>, @@ -1334,7 +1334,7 @@ usbmisc2: > > usbmisc@4c200200 { > > > #index-cells = <1>; > > > }; > > > > > > - ddr-pmu@4e300dc0 { > > > + ddr_pmu: ddr-pmu@4e300dc0 { > > > > Useless commit - there are no users. > Thanks for your comments! > Have used the labels in imx91.dtsi. The imx91.dtsi have included the imx93.dtsi. That's patch 5/5 so I say: impossible. Either you did not understand the commit or your patchset is non-bisectable, so anyway that's wrong or fix your builds. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2025年1月21日 17:04 > To: Joy Zou <joy.zou@nxp.com> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; catalin.marinas@arm.com; > will@kernel.org; kernel@pengutronix.de; festevam@gmail.com; > joao.goncalves@toradex.com; marex@denx.de; hvilleneuve@dimonoff.com; > hiago.franco@toradex.com; Peng Fan <peng.fan@nxp.com>; > frieder.schrempf@kontron.de; alexander.stein@ew.tq-group.com; > m.othacehe@gmail.com; mwalle@kernel.org; Max.Merchel@ew.tq-group.com; > quic_bjorande@quicinc.com; geert+renesas@glider.be; > dmitry.baryshkov@linaro.org; neil.armstrong@linaro.org; arnd@arndb.de; > nfraprado@collabora.com; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org; Jacky Bai <ping.bai@nxp.com>; Ye Li > <ye.li@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; Frank Li > <frank.li@nxp.com>; Carlos Song <carlos.song@nxp.com> > Subject: Re: [EXT] Re: [PATCH v4 5/5] arm64: dts: imx93: Add labels for the > references easier > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Tue, Jan 21, 2025 at 08:25:51AM +0000, Joy Zou wrote: > > > THERMAL_NO_LIMIT > > > > THERMAL_NO_LIMIT>, @@ -1334,7 +1334,7 @@ usbmisc2: > > > usbmisc@4c200200 { > > > > #index-cells = <1>; > > > > }; > > > > > > > > - ddr-pmu@4e300dc0 { > > > > + ddr_pmu: ddr-pmu@4e300dc0 { > > > > > > Useless commit - there are no users. > > Thanks for your comments! > > Have used the labels in imx91.dtsi. The imx91.dtsi have included the > imx93.dtsi. > > That's patch 5/5 so I say: impossible. > > Either you did not understand the commit or your patchset is non-bisectable, > so anyway that's wrong or fix your builds. Thanks your comments! I got it, the imx91 dtsi patch depends on imx93 patch, so need commit firstly the imx93 patch, Otherwise, will build break. Will adjust the sequence in next patch version. BR Joy Zou > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi index 56766fdb0b1e..4739e7cb7e9b 100644 --- a/arch/arm64/boot/dts/freescale/imx93.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi @@ -206,7 +206,7 @@ cpu_crit: cpu-crit { }; cooling-maps { - map0 { + map0: map0 { trip = <&cpu_alert>; cooling-device = <&A55_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, @@ -1334,7 +1334,7 @@ usbmisc2: usbmisc@4c200200 { #index-cells = <1>; }; - ddr-pmu@4e300dc0 { + ddr_pmu: ddr-pmu@4e300dc0 { compatible = "fsl,imx93-ddr-pmu"; reg = <0x4e300dc0 0x200>; interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
Making the references easier, so add labels. Signed-off-by: Joy Zou <joy.zou@nxp.com> --- arch/arm64/boot/dts/freescale/imx93.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)