diff mbox series

[v4,4/5] arm64: defconfig: enable i.MX91 pinctrl

Message ID 20250121074017.2819285-5-joy.zou@nxp.com (mailing list archive)
State New
Headers show
Series Add i.MX91 platform support | expand

Commit Message

Joy Zou Jan. 21, 2025, 7:40 a.m. UTC
From: Pengfei Li <pengfei.li_1@nxp.com>

Enable i.MX91 pinctrl driver for booting the system

Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Jan. 21, 2025, 7:50 a.m. UTC | #1
On 21/01/2025 08:40, Joy Zou wrote:
> From: Pengfei Li <pengfei.li_1@nxp.com>
> 
> Enable i.MX91 pinctrl driver for booting the system

That's really poor commit msg. You are changing common defconfig, not
your own. Booting system of what soc? What product? Why would we like to
have it, if there is no board with it?

Best regards,
Krzysztof
Joy Zou Jan. 21, 2025, 10:32 a.m. UTC | #2
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 2025年1月21日 15:51
> To: Joy Zou <joy.zou@nxp.com>; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> catalin.marinas@arm.com; will@kernel.org; kernel@pengutronix.de;
> festevam@gmail.com
> Cc: joao.goncalves@toradex.com; marex@denx.de;
> hvilleneuve@dimonoff.com; hiago.franco@toradex.com; Peng Fan
> <peng.fan@nxp.com>; frieder.schrempf@kontron.de;
> alexander.stein@ew.tq-group.com; m.othacehe@gmail.com;
> mwalle@kernel.org; Max.Merchel@ew.tq-group.com;
> quic_bjorande@quicinc.com; geert+renesas@glider.be;
> dmitry.baryshkov@linaro.org; neil.armstrong@linaro.org; arnd@arndb.de;
> nfraprado@collabora.com; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; Jacky Bai <ping.bai@nxp.com>; Ye Li
> <ye.li@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; Frank Li
> <frank.li@nxp.com>; Carlos Song <carlos.song@nxp.com>
> Subject: [EXT] Re: [PATCH v4 4/5] arm64: defconfig: enable i.MX91 pinctrl
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 21/01/2025 08:40, Joy Zou wrote:
> > From: Pengfei Li <pengfei.li_1@nxp.com>
> >
> > Enable i.MX91 pinctrl driver for booting the system
> 
> That's really poor commit msg. You are changing common defconfig, not your
> own. Booting system of what soc? What product? Why would we like to have
> it, if there is no board with it?
Thanks your comments!
Will modify the commit message according to your question.
BR
Joy Zou
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 246a13412bf0..b16c924fd8aa 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -598,6 +598,7 @@  CONFIG_PINCTRL_IMX8QM=y
 CONFIG_PINCTRL_IMX8QXP=y
 CONFIG_PINCTRL_IMX8DXL=y
 CONFIG_PINCTRL_IMX8ULP=y
+CONFIG_PINCTRL_IMX91=y
 CONFIG_PINCTRL_IMX93=y
 CONFIG_PINCTRL_MSM=y
 CONFIG_PINCTRL_IPQ5018=y