| Message ID | 20250121103254.2528004-11-andyshrk@163.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | VOP Support for rk3576 | expand |
On Tue, Jan 21, 2025 at 06:32:47PM +0800, Andy Yan wrote: > From: Andy Yan <andy.yan@rock-chips.com> > > As more SoCs variants are introduced, each SoC brings its own > unique set of constraints, describe this constraints SoC by > SoC will make things easier for adding new variant. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > --- > > Changes in v12: > - Only change the description method for existing SoC. > > Changes in v11: > - Remove redundant min/maxItems constraint > > Changes in v10: > - Move interrupt-names back to top level > - Add constraint of interrupts for all platform > - Add constraint for all grf phandles > - Reorder some properties > > Changes in v9: > - Drop 'vop-' prefix of interrupt-names. > - Add blank line between DT properties > - Remove list interrupt-names in top level > > Changes in v8: > - Fix dt_binding_check errors > - ordered by soc name > - Link to the previous version: > https://lore.kernel.org/linux-rockchip/6pn3qjxotdtpzucpul24yro7ppddezwuizneovqvmgdwyv2j7p@ztg4mqyiqmjf/T/#u > > Changes in v4: > - describe constraint SOC by SOC, as interrupts of rk3576 is very > different from others > - Drop Krzysztof's Reviewed-by, as this version changed a lot. > > Changes in v3: > - ordered by soc name > - Add description for newly added interrupt > > Changes in v2: > - Add dt bindings > > .../display/rockchip/rockchip-vop2.yaml | 44 +++++++++++++------ > 1 file changed, 30 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 2531726af306..f23939e67fd0 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -14,6 +14,7 @@ description: > maintainers: > - Sandy Huang <hjc@rock-chips.com> > - Heiko Stuebner <heiko@sntech.de> > + - Andy Yan <andyshrk@163.com> > > properties: > compatible: > @@ -120,43 +121,58 @@ allOf: > properties: > compatible: > contains: > - const: rockchip,rk3588-vop > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > then: > properties: > clocks: > - minItems: 7 > + minItems: 5 I don't see any changes comparing to original binding. At least not for clocks. > + > clock-names: > - minItems: 7 > + minItems: 5 > + > + interrupts: > + maxItems: 1 This is useless and not explained. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 2531726af306..f23939e67fd0 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml @@ -14,6 +14,7 @@ description: maintainers: - Sandy Huang <hjc@rock-chips.com> - Heiko Stuebner <heiko@sntech.de> + - Andy Yan <andyshrk@163.com> properties: compatible: @@ -120,43 +121,58 @@ allOf: properties: compatible: contains: - const: rockchip,rk3588-vop + enum: + - rockchip,rk3566-vop + - rockchip,rk3568-vop then: properties: clocks: - minItems: 7 + minItems: 5 + clock-names: - minItems: 7 + minItems: 5 + + interrupts: + maxItems: 1 ports: required: - port@0 - port@1 - port@2 - - port@3 - - required: - - rockchip,grf - - rockchip,vo1-grf - - rockchip,vop-grf - - rockchip,pmu - else: - properties: rockchip,vo1-grf: false rockchip,vop-grf: false rockchip,pmu: false + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-vop + then: + properties: clocks: - maxItems: 5 + minItems: 7 + clock-names: - maxItems: 5 + minItems: 7 + + interrupts: + maxItems: 1 ports: required: - port@0 - port@1 - port@2 + - port@3 + + required: + - rockchip,grf + - rockchip,vo1-grf + - rockchip,vop-grf + - rockchip,pmu additionalProperties: false