diff mbox series

[v12,11/13] dt-bindings: display: vop2: Add missing rockchip, grf propertie for rk3566/8

Message ID 20250121103446.2528212-1-andyshrk@163.com (mailing list archive)
State New
Headers show
Series VOP Support for rk3576 | expand

Commit Message

Andy Yan Jan. 21, 2025, 10:34 a.m. UTC 
From: Andy Yan <andy.yan@rock-chips.com>

Propertie "rockchip,grf" is required for rk3566/8.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

---

Changes in v12:
- Split from patch 10/13

 .../devicetree/bindings/display/rockchip/rockchip-vop2.yaml   | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Jan. 22, 2025, 8:03 a.m. UTC | #1 
On Tue, Jan 21, 2025 at 06:34:44PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> Propertie "rockchip,grf" is required for rk3566/8.

Fix typos.

Why? What we see from the diff...

Best regards,
Krzysztof
Andy Yan Jan. 22, 2025, 9:29 a.m. UTC | #2 
Hi
At 2025-01-22 16:03:00, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On Tue, Jan 21, 2025 at 06:34:44PM +0800, Andy Yan wrote:
>> From: Andy Yan <andy.yan@rock-chips.com>
>> 
>> Propertie "rockchip,grf" is required for rk3566/8.
>
>Fix typos.
>
>Why? What we see from the diff...

This property is used in dts, see vop dt node in rk356x-base.dtsi,
but not required in the binding.

>
>Best regards,
>Krzysztof
Krzysztof Kozlowski Jan. 22, 2025, 9:43 a.m. UTC | #3 
On 22/01/2025 10:29, Andy Yan wrote:
> 
> Hi
> At 2025-01-22 16:03:00, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>> On Tue, Jan 21, 2025 at 06:34:44PM +0800, Andy Yan wrote:
>>> From: Andy Yan <andy.yan@rock-chips.com>
>>>
>>> Propertie "rockchip,grf" is required for rk3566/8.
>>
>> Fix typos.
>>
>> Why? What we see from the diff...
> 
> This property is used in dts, see vop dt node in rk356x-base.dtsi,


This is not the reason to make it a required property.

Best regards,
Krzysztof
Andy Yan Jan. 22, 2025, 9:52 a.m. UTC | #4 
Hi

At 2025-01-22 17:43:34, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On 22/01/2025 10:29, Andy Yan wrote:
>> 
>> Hi
>> At 2025-01-22 16:03:00, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>>> On Tue, Jan 21, 2025 at 06:34:44PM +0800, Andy Yan wrote:
>>>> From: Andy Yan <andy.yan@rock-chips.com>
>>>>
>>>> Propertie "rockchip,grf" is required for rk3566/8.
>>>
>>> Fix typos.
>>>
>>> Why? What we see from the diff...
>> 
>> This property is used in dts, see vop dt node in rk356x-base.dtsi,
>
>
>This is not the reason to make it a required property.

The Clock Polarity of RGB signal output is controlled by GRF.
 
>
>Best regards,
>Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
index f23939e67fd0..157a37ed84da 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
@@ -145,6 +145,9 @@  allOf:
         rockchip,vop-grf: false
         rockchip,pmu: false
 
+      required:
+        - rockchip,grf
+
   - if:
       properties:
         compatible:
@@ -200,6 +203,7 @@  examples:
                               "dclk_vp1",
                               "dclk_vp2";
                 power-domains = <&power RK3568_PD_VO>;
+                rockchip,grf = <&grf>;
                 iommus = <&vop_mmu>;
                 vop_out: ports {
                     #address-cells = <1>;