| Message ID | 20250122-socfpga_sip_svc_misc-v1-2-cbdcd034ae34@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | stratix10: miscellaneous changes and fix for child driver probing | expand |
Hi Mahesh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on ffd294d346d185b70e28b1a28abe367bbfe53c04]
url: https://github.com/intel-lab-lkp/linux/commits/Mahesh-Rao/dt-bindings-fpga-stratix10-Convert-to-json-schema/20250122-140026
base: ffd294d346d185b70e28b1a28abe367bbfe53c04
patch link: https://lore.kernel.org/r/20250122-socfpga_sip_svc_misc-v1-2-cbdcd034ae34%40intel.com
patch subject: [PATCH 2/3] dt-bindings: firmware: stratix10: Convert to json-schema
reproduce: (https://download.01.org/0day-ci/archive/20250122/202501221710.7llON7lZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501221710.7llON7lZ-lkp@intel.com/
All warnings (new ones prefixed by >>):
Warning: Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/siliconmitus,sm5703.yaml
Warning: Documentation/hwmon/g762.rst references a file that doesn't exist: Documentation/devicetree/bindings/hwmon/g762.txt
Warning: Documentation/hwmon/isl28022.rst references a file that doesn't exist: Documentation/devicetree/bindings/hwmon/isl,isl28022.yaml
Warning: Documentation/translations/ja_JP/SubmittingPatches references a file that doesn't exist: linux-2.6.12-vanilla/Documentation/dontdiff
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/firmware/intel,stratix10-svc.txt
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt
Warning: lib/Kconfig.debug references a file that doesn't exist: Documentation/dev-tools/fault-injection/fault-injection.rst
Using alabaster theme
On Wed, Jan 22, 2025 at 01:58:44PM +0800, Mahesh Rao wrote: > Convert intel,stratix10-svc service layer devicetree > binding file from freeform format to json-schema. > diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..b8aae996da87c16007efa7e5e12cced1432b62e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/intel,stratix10-svc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel Service Layer Driver for Stratix10 SoC > + > +maintainers: > + - Dinh Nguyen <dinguyen@kernel.org> > + > +description: | > + Intel Stratix10 SoC is composed of a 64 bit quad-core ARM Cortex A53 hard > + processor system (HPS) and Secure Device Manager (SDM). When the FPGA is > + configured from HPS, there needs to be a way for HPS to notify SDM the > + location and size of the configuration data. Then SDM will get the > + configuration data from that location and perform the FPGA configuration. > + > + To meet the whole system security needs and support virtual machine requesting > + communication with SDM, only the secure world of software (EL3, Exception > + Layer 3) can interface with SDM. All software entities running on other > + exception layers must channel through the EL3 software whenever it needs > + service from SDM. > + > + Intel Stratix10 service layer driver, running at privileged exception level > + (EL1, Exception Layer 1), interfaces with the service providers and provides > + the services for FPGA configuration, QSPI, Crypto and warm reset. Service layer > + driver also manages secure monitor call (SMC) to communicate with secure monitor > + code running in EL3. > + > +properties: > + compatible: > + enum: > + - intel,stratix10-svc > + - intel,agilex-svc > + > + method: > + enum: [smc, hvc] > + description: supervisory call method to be used for the service layer. This looks to be missing a type (string) and an explanation of what "smc" and "hvc" are. > + > + memory-region: > + maxItems: 1 > + description: > + phandle to a reserved memory region for the service layer driver to > + communicate with the secure device manager. For more details see > + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt. > + > + fpga-mgr: > + $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml > + description: Optional child node for fpga manager to perform fabric configuration. This is new and not justified in your commit message. Please explain where this has come from in v2. Cheers, Conor. > + > +required: > + - compatible > + - method > + - memory-region > + > +additionalProperties: false > + > +examples: > + - | > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + > + service_reserved: svcbuffer@0 { > + compatible = "shared-dma-pool"; > + reg = <0x0 0x0 0x0 0x1000000>; > + alignment = <0x1000>; > + no-map; > + }; > + }; > + > + firmware { > + svc { > + compatible = "intel,stratix10-svc"; > + method = "smc"; > + memory-region = <&service_reserved>; > + > + fpga-mgr { > + compatible = "intel,stratix10-soc-fpga-mgr"; > + }; > + }; > + }; > + > > -- > 2.35.3 >
diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.txt b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.txt deleted file mode 100644 index 6eff1afd8daf91714d6a18859667d2607e707da7..0000000000000000000000000000000000000000 --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.txt +++ /dev/null @@ -1,57 +0,0 @@ -Intel Service Layer Driver for Stratix10 SoC -============================================ -Intel Stratix10 SoC is composed of a 64 bit quad-core ARM Cortex A53 hard -processor system (HPS) and Secure Device Manager (SDM). When the FPGA is -configured from HPS, there needs to be a way for HPS to notify SDM the -location and size of the configuration data. Then SDM will get the -configuration data from that location and perform the FPGA configuration. - -To meet the whole system security needs and support virtual machine requesting -communication with SDM, only the secure world of software (EL3, Exception -Layer 3) can interface with SDM. All software entities running on other -exception layers must channel through the EL3 software whenever it needs -service from SDM. - -Intel Stratix10 service layer driver, running at privileged exception level -(EL1, Exception Layer 1), interfaces with the service providers and provides -the services for FPGA configuration, QSPI, Crypto and warm reset. Service layer -driver also manages secure monitor call (SMC) to communicate with secure monitor -code running in EL3. - -Required properties: -------------------- -The svc node has the following mandatory properties, must be located under -the firmware node. - -- compatible: "intel,stratix10-svc" or "intel,agilex-svc" -- method: smc or hvc - smc - Secure Monitor Call - hvc - Hypervisor Call -- memory-region: - phandle to the reserved memory node. See - Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt - for details - -Example: -------- - - reserved-memory { - #address-cells = <2>; - #size-cells = <2>; - ranges; - - service_reserved: svcbuffer@0 { - compatible = "shared-dma-pool"; - reg = <0x0 0x0 0x0 0x1000000>; - alignment = <0x1000>; - no-map; - }; - }; - - firmware { - svc { - compatible = "intel,stratix10-svc"; - method = "smc"; - memory-region = <&service_reserved>; - }; - }; diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml new file mode 100644 index 0000000000000000000000000000000000000000..b8aae996da87c16007efa7e5e12cced1432b62e9 --- /dev/null +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml @@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/intel,stratix10-svc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Intel Service Layer Driver for Stratix10 SoC + +maintainers: + - Dinh Nguyen <dinguyen@kernel.org> + +description: | + Intel Stratix10 SoC is composed of a 64 bit quad-core ARM Cortex A53 hard + processor system (HPS) and Secure Device Manager (SDM). When the FPGA is + configured from HPS, there needs to be a way for HPS to notify SDM the + location and size of the configuration data. Then SDM will get the + configuration data from that location and perform the FPGA configuration. + + To meet the whole system security needs and support virtual machine requesting + communication with SDM, only the secure world of software (EL3, Exception + Layer 3) can interface with SDM. All software entities running on other + exception layers must channel through the EL3 software whenever it needs + service from SDM. + + Intel Stratix10 service layer driver, running at privileged exception level + (EL1, Exception Layer 1), interfaces with the service providers and provides + the services for FPGA configuration, QSPI, Crypto and warm reset. Service layer + driver also manages secure monitor call (SMC) to communicate with secure monitor + code running in EL3. + +properties: + compatible: + enum: + - intel,stratix10-svc + - intel,agilex-svc + + method: + enum: [smc, hvc] + description: supervisory call method to be used for the service layer. + + memory-region: + maxItems: 1 + description: + phandle to a reserved memory region for the service layer driver to + communicate with the secure device manager. For more details see + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt. + + fpga-mgr: + $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml + description: Optional child node for fpga manager to perform fabric configuration. + +required: + - compatible + - method + - memory-region + +additionalProperties: false + +examples: + - | + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + + service_reserved: svcbuffer@0 { + compatible = "shared-dma-pool"; + reg = <0x0 0x0 0x0 0x1000000>; + alignment = <0x1000>; + no-map; + }; + }; + + firmware { + svc { + compatible = "intel,stratix10-svc"; + method = "smc"; + memory-region = <&service_reserved>; + + fpga-mgr { + compatible = "intel,stratix10-soc-fpga-mgr"; + }; + }; + }; +
Convert intel,stratix10-svc service layer devicetree binding file from freeform format to json-schema. Signed-off-by: Mahesh Rao <mahesh.rao@intel.com> --- .../bindings/firmware/intel,stratix10-svc.txt | 57 --------------- .../bindings/firmware/intel,stratix10-svc.yaml | 84 ++++++++++++++++++++++ 2 files changed, 84 insertions(+), 57 deletions(-)