| Message ID | 20250110123835.2719824-5-paul-pl.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
Hi Rob Thanks for the advice. The root cause of the erroneous log message is due to missing power/clock dependencies. Once the MTK clock/power header file is upstreamed, we will include a reference link in the next version of the upstream series submission. Best, Paul-pl Chen -----Original Message----- From: Rob Herring (Arm) <robh@kernel.org> Sent: Friday, January 10, 2025 9:54 PM To: Paul-pl Chen (陳柏霖) <Paul-pl.Chen@mediatek.com> Cc: conor+dt@kernel.org; Singo Chang (張興國) <Singo.Chang@mediatek.com>; Sunny Shen (沈姍姍) <Sunny.Shen@mediatek.com>; chunkuang.hu@kernel.org; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com>; fshao@chromium.org; Sirius Wang (王皓昱) <Sirius.Wang@mediatek.com>; dri-devel@lists.freedesktop.org; matthias.bgg@gmail.com; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Xiandong Wang (王先冬) <Xiandong.Wang@mediatek.com>; treapking@chromium.org; Nancy Lin (林欣螢) <Nancy.Lin@mediatek.com>; linux-mediatek@lists.infradead.org; p.zabel@pengutronix.de; Jason-JH Lin (林睿祥) <Jason-JH.Lin@mediatek.com>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; linux-arm-kernel@lists.infradead.org; krzk+dt@kernel.org Subject: Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196 External email : Please do not click links or open attachments until you have verified the sender or the content. On Fri, 10 Jan 2025 20:33:59 +0800, paul-pl.chen wrote: > From: "Paul-pl.Chen" <paul-pl.chen@mediatek.com> > > Add mediatek,exdma.yaml to support EXDMA for MT8196. > > Signed-off-by: Paul-pl.Chen <paul-pl.chen@mediatek.com> > --- > The header used in examples: > #include <dt-bindings/clock/mt8196-clk.h> #include > <dt-bindings/power/mt8196-power.h> > are not upstreamed yet. > It will be sent by related owner soon. > --- > .../display/mediatek/mediatek,exdma.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dts:18:18: fatal error: dt-bindings/clock/mt8196-clk.h: No such file or directory 18 | #include <dt-bindings/clock/mt8196-clk.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250110123835.2719824-5-paul-pl.chen@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Il 14/01/25 06:49, Paul-pl Chen (陳柏霖) ha scritto: > Hi Rob > Thanks for the advice. > The root cause of the erroneous log message is due to missing power/clock dependencies. > Once the MTK clock/power header file is upstreamed, The mt8196-clk/power.h filenames are anyway wrong for upstream.... :-) Cheers, Angelo > we will include a reference link in the next version of the upstream series submission. > > Best, Paul-pl Chen > > -----Original Message----- > From: Rob Herring (Arm) <robh@kernel.org> > Sent: Friday, January 10, 2025 9:54 PM > To: Paul-pl Chen (陳柏霖) <Paul-pl.Chen@mediatek.com> > Cc: conor+dt@kernel.org; Singo Chang (張興國) <Singo.Chang@mediatek.com>; Sunny Shen (沈姍姍) <Sunny.Shen@mediatek.com>; chunkuang.hu@kernel.org; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com>; fshao@chromium.org; Sirius Wang (王皓昱) <Sirius.Wang@mediatek.com>; dri-devel@lists.freedesktop.org; matthias.bgg@gmail.com; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Xiandong Wang (王先冬) <Xiandong.Wang@mediatek.com>; treapking@chromium.org; Nancy Lin (林欣螢) <Nancy.Lin@mediatek.com>; linux-mediatek@lists.infradead.org; p.zabel@pengutronix.de; Jason-JH Lin (林睿祥) <Jason-JH.Lin@mediatek.com>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; linux-arm-kernel@lists.infradead.org; krzk+dt@kernel.org > Subject: Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196 > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > On Fri, 10 Jan 2025 20:33:59 +0800, paul-pl.chen wrote: >> From: "Paul-pl.Chen" <paul-pl.chen@mediatek.com> >> >> Add mediatek,exdma.yaml to support EXDMA for MT8196. >> >> Signed-off-by: Paul-pl.Chen <paul-pl.chen@mediatek.com> >> --- >> The header used in examples: >> #include <dt-bindings/clock/mt8196-clk.h> #include >> <dt-bindings/power/mt8196-power.h> >> are not upstreamed yet. >> It will be sent by related owner soon. >> --- >> .../display/mediatek/mediatek,exdma.yaml | 77 +++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dts:18:18: fatal error: dt-bindings/clock/mt8196-clk.h: No such file or directory > 18 | #include <dt-bindings/clock/mt8196-clk.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 > make: *** [Makefile:251: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250110123835.2719824-5-paul-pl.chen@mediatek.com > > The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. >
On Tue, 2025-01-14 at 11:34 +0100, AngeloGioacchino Del Regno wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 14/01/25 06:49, Paul-pl Chen (陳柏霖) ha scritto: > > Hi Rob > > Thanks for the advice. > > The root cause of the erroneous log message is due to missing > > power/clock dependencies. > > Once the MTK clock/power header file is upstreamed, > > The mt8196-clk/power.h filenames are anyway wrong for upstream.... :- > ) > > Cheers, > Angelo > Hi, Angelo may I ask if you mean that the filenames "mt8196-clk/power.h "need to be changed to the following? "mediatek,mt8188-clk.h" "mediatek,mt8188-power.h" If so, we will ask the Mediatek clock/power owner to submit them according to the correct upstream format. > Best, Paul //snip
On 14/01/2025 06:49, Paul-pl Chen (陳柏霖) wrote: > Hi Rob > Thanks for the advice. > The root cause of the erroneous log message is due to missing power/clock dependencies. > Once the MTK clock/power header file is upstreamed, So this cannot be merged. Decouple dependencies or wait with your submission till depenedncy is applied to *LINUS* tree, not even maintainer. Otherwise this breaks maintainer's tree. I really suggest decoupling. Best regards, Krzysztof
On Sat, 2025-01-18 at 10:22 +0100, Krzysztof Kozlowski wrote: > Decouple dependencies or wait with your submission till depenedncy is > applied to *LINUS* tree, not even maintainer. Otherwise this breaks > maintainer's tree. I really suggest decoupling. > > Best regards, > Krzysztof Thanks for the suggestion, We will wait the dependency commit is applied to *LINUS* tree. Best regards, Paul
On Sat, 2025-01-18 at 10:22 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 14/01/2025 06:49, Paul-pl Chen (陳柏霖) wrote: > > Hi Rob > > Thanks for the advice. > > The root cause of the erroneous log message is due to missing > > power/clock dependencies. > > Once the MTK clock/power header file is upstreamed, > So this cannot be merged. > > Decouple dependencies or wait with your submission till depenedncy is > applied to *LINUS* tree, not even maintainer. Otherwise this breaks > maintainer's tree. I really suggest decoupling. > > Best regards, > Krzysztof > Hi Krzysztof I hope this email finds you well. I have a couple of questions regarding the EXDMA commit patch and decoupling: 1. Would removing the example from the EXDMA commit patch be sufficient to achieve decoupling for EXDMA YAML and MTK clock/power header? 2. If removing the example from the EXDMA YAML is not allowed, what alternative changes could we implement to achieve decoupling? Thank you for your time and expertise. I appreciate any insights you can provide. Best regards, Paul
On Thu, Jan 23, 2025 at 2:11 PM Paul-pl Chen (陳柏霖) <Paul-pl.Chen@mediatek.com> wrote: > > On Sat, 2025-01-18 at 10:22 +0100, Krzysztof Kozlowski wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > On 14/01/2025 06:49, Paul-pl Chen (陳柏霖) wrote: > > > Hi Rob > > > Thanks for the advice. > > > The root cause of the erroneous log message is due to missing > > > power/clock dependencies. > > > Once the MTK clock/power header file is upstreamed, > > So this cannot be merged. > > > > Decouple dependencies or wait with your submission till depenedncy is > > applied to *LINUS* tree, not even maintainer. Otherwise this breaks > > maintainer's tree. I really suggest decoupling. > > > > Best regards, > > Krzysztof > > > > Hi Krzysztof > > I hope this email finds you well. I have a couple of questions > regarding the EXDMA commit patch and decoupling: > > 1. Would removing the example from the EXDMA commit patch be sufficient > to achieve decoupling for EXDMA YAML and MTK clock/power header? > > 2. If removing the example from the EXDMA YAML is not allowed, what > alternative changes could we implement to achieve decoupling? Just replace the macros in the example with the raw numbers, and drop the inclusion of the header. ChenYu > Thank you for your time and expertise. I appreciate any insights you > can provide. > > Best regards, > > Paul > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!
On 23/01/2025 07:11, Paul-pl Chen (陳柏霖) wrote: > > Hi Krzysztof > > I hope this email finds you well. I have a couple of questions > regarding the EXDMA commit patch and decoupling: > > 1. Would removing the example from the EXDMA commit patch be sufficient > to achieve decoupling for EXDMA YAML and MTK clock/power header? No > > 2. If removing the example from the EXDMA YAML is not allowed, what > alternative changes could we implement to achieve decoupling? Don't use the header constants but just some fake phandle. Best regards, Krzysztof
On Thu, 2025-01-23 at 14:25 +0800, Chen-Yu Tsai wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Thu, Jan 23, 2025 at 2:11 PM Paul-pl Chen (陳柏霖) > <Paul-pl.Chen@mediatek.com> wrote: > > > > On Sat, 2025-01-18 at 10:22 +0100, Krzysztof Kozlowski wrote: > > > > > > External email : Please do not click links or open attachments > > > until > > > you have verified the sender or the content. > > > > > > > > > On 14/01/2025 06:49, Paul-pl Chen (陳柏霖) wrote: > > > > Hi Rob > > > > Thanks for the advice. > > > > The root cause of the erroneous log message is due to missing > > > > power/clock dependencies. > > > > Once the MTK clock/power header file is upstreamed, > > > So this cannot be merged. > > > > > > Decouple dependencies or wait with your submission till > > > depenedncy is > > > applied to *LINUS* tree, not even maintainer. Otherwise this > > > breaks > > > maintainer's tree. I really suggest decoupling. > > > > > > Best regards, > > > Krzysztof > > > > > > > Hi Krzysztof > > > > I hope this email finds you well. I have a couple of questions > > regarding the EXDMA commit patch and decoupling: > > > > 1. Would removing the example from the EXDMA commit patch be > > sufficient > > to achieve decoupling for EXDMA YAML and MTK clock/power header? > > > > 2. If removing the example from the EXDMA YAML is not allowed, what > > alternative changes could we implement to achieve decoupling? > > Just replace the macros in the example with the raw numbers, and > drop the inclusion of the header. > > ChenYu > > Hi ChenYu Thanks for the review and suggestion. Best Regards, Paul
On Thu, 2025-01-23 at 08:21 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 23/01/2025 07:11, Paul-pl Chen (陳柏霖) wrote: > > > > Hi Krzysztof > > > > I hope this email finds you well. I have a couple of questions > > regarding the EXDMA commit patch and decoupling: > > > > 1. Would removing the example from the EXDMA commit patch be > > sufficient > > to achieve decoupling for EXDMA YAML and MTK clock/power header? > > No > > > > > 2. If removing the example from the EXDMA YAML is not allowed, what > > alternative changes could we implement to achieve decoupling? > > Don't use the header constants but just some fake phandle. > > > > Best regards, > Krzysztof Hi Krzysztof, Once again, thanks for the review and reply. SO If we apply Chenyu's suggestion: + example: + -| + soc { + + disp_ovl0_exdma2: dma-controller@32850000 { + compatible = "mediatek,mt8196-exdma"; + reg = <0 0x32850000 0 0x1000>; + clocks = <13>; + power-domains = <12>; + mediatek,larb = <88>; + iommus = <&mm_smmu 144>; + #dma-cells = <1>; + }; + }; Does this work for decoupling? Best Regards, Paul
On Fri, Jan 24, 2025 at 12:14 AM Paul-pl Chen (陳柏霖) <Paul-pl.Chen@mediatek.com> wrote: > > On Thu, 2025-01-23 at 08:21 +0100, Krzysztof Kozlowski wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > On 23/01/2025 07:11, Paul-pl Chen (陳柏霖) wrote: > > > > > > Hi Krzysztof > > > > > > I hope this email finds you well. I have a couple of questions > > > regarding the EXDMA commit patch and decoupling: > > > > > > 1. Would removing the example from the EXDMA commit patch be > > > sufficient > > > to achieve decoupling for EXDMA YAML and MTK clock/power header? > > > > No > > > > > > > > 2. If removing the example from the EXDMA YAML is not allowed, what > > > alternative changes could we implement to achieve decoupling? > > > > Don't use the header constants but just some fake phandle. > > > > > > > > Best regards, > > Krzysztof > > Hi Krzysztof, > > Once again, thanks for the review and reply. > > SO If we apply Chenyu's suggestion: > > + example: > +-| > > +soc { > + > + disp_ovl0_exdma2: dma-controller@32850000 { > +compatible = "mediatek,mt8196-exdma"; > +reg = <0 0x32850000 0 0x1000>; > +clocks = <13>; > +power-domains = <12>; > +mediatek,larb = <88>; > +iommus = <&mm_smmu 144>; > +#dma-cells = <1>; > + }; > + }; > > Does this work for decoupling? > AFAIK it will since now it isn't including any headers. ChenYu > Best Regards, > > Paul > > > > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml new file mode 100644 index 000000000000..385f5549dfaa --- /dev/null +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/mediatek/mediatek,exdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek EXDMA + +maintainers: + - Chun-Kuang Hu <chunkuang.hu@kernel.org> + - Philipp Zabel <p.zabel@pengutronix.de> + +description: + The MediaTek display overlap extended DMA engine, namely OVL_EXDMA or EXDMA, + primarily functions as a DMA engine for reading data from DRAM with various + DRAM footprints and data formats. For input sources in certain color formats + and color domains, OVL_EXDMA also includes a color transfer function + to process pixels into a consistent color domain. + +properties: + compatible: + const: mediatek,mt8196-exdma + + reg: + maxItems: 1 + + clocks: + items: + - description: EXDMA Clock + + power-domains: + maxItems: 1 + + mediatek,larb: + $ref: /schemas/types.yaml#/definitions/phandle-array + maxItems: 1 + items: + maxItems: 1 + description: | + A phandle to the local arbiters node in the current SoCs. + Refer to bindings/memory-controllers/mediatek,smi-larb.yaml. + + iommus: + maxItems: 1 + + '#dma-cells': + const: 1 + +required: + - compatible + - reg + - clocks + - power-domains + - mediatek,larb + - iommus + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8196-clk.h> + #include <dt-bindings/power/mt8196-power.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + disp_ovl0_exdma2: dma-controller@32850000 { + compatible = "mediatek,mt8196-exdma"; + reg = <0 0x32850000 0 0x1000>; + clocks = <&ovlsys_config_clk CLK_OVL_EXDMA2_DISP>; + power-domains = <&hfrpsys MT8196_POWER_DOMAIN_OVL0_DORMANT>; + mediatek,larb = <&smi_larb0>; + iommus = <&mm_smmu 144>; + #dma-cells = <1>; + }; + };