| Message ID | d4893396c4bacdd995d03a296b9d3ff44e71d072.1737631669.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | cpufreq: manage common sysfs attributes from core | expand |
On Thu, Jan 23, 2025 at 05:06:00PM +0530, Viresh Kumar wrote: > The cpufreq core handles this for basic attributes now, the driver can skip > setting them. > I know this is boiler plate commit message but it made me go check if boosts are handled too even though I checked it in 01/33. So if possible, you can add "basic attributes including boost frequencies", that would be good, aligns with the change below and makes it easy to refer in the future if required. Not a must, I will leave that to you. Anyways, Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
On 23-01-25, 12:01, Sudeep Holla wrote: > On Thu, Jan 23, 2025 at 05:06:00PM +0530, Viresh Kumar wrote: > > The cpufreq core handles this for basic attributes now, the driver can skip > > setting them. > > > > I know this is boiler plate commit message but it made me go check if boosts > are handled too even though I checked it in 01/33. So if possible, you can > add "basic attributes including boost frequencies", that would be good, > aligns with the change below and makes it easy to refer in the future if > required. Not a must, I will leave that to you. Anyways, Even if it creates doubt for a single person, its better to go fix it (for all commits). I will do that while applying the series (unless I need to send another version now for other reasons).
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index b8fe758aeb01..4a3ee59cb771 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -171,12 +171,6 @@ scmi_get_rate_limit(u32 domain, bool has_fast_switch) return rate_limit; } -static struct freq_attr *scmi_cpufreq_hw_attr[] = { - &cpufreq_freq_attr_scaling_available_freqs, - NULL, - NULL, -}; - static int scmi_limit_notify_cb(struct notifier_block *nb, unsigned long event, void *data) { struct scmi_data *priv = container_of(nb, struct scmi_data, limit_notify_nb); @@ -309,7 +303,6 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) dev_warn(cpu_dev, "failed to enable boost: %d\n", ret); goto out_free_table; } else { - scmi_cpufreq_hw_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs; scmi_cpufreq_driver.boost_enabled = true; } } @@ -395,7 +388,6 @@ static struct cpufreq_driver scmi_cpufreq_driver = { CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, - .attr = scmi_cpufreq_hw_attr, .target_index = scmi_cpufreq_set_target, .fast_switch = scmi_cpufreq_fast_switch, .get = scmi_cpufreq_get_rate,
The cpufreq core handles this for basic attributes now, the driver can skip setting them. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/scmi-cpufreq.c | 8 -------- 1 file changed, 8 deletions(-)