| Message ID | 20250123-timodulemailboxsci-v4-1-b1a31b56f162@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4] arm64: arch_k3: Replace select with imply for TI mailbox and TI SCI | expand |
On 1/23/25 6:12 AM, Guillaume La Roque wrote: > In order to build TI mailbox and TI SCI as modules, replace > select with imply. > > Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com> > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > --- > Changes in v4: > - rebase on master branch > - Link to v3: https://lore.kernel.org/r/20241016-timodulemailboxsci-v3-1-0e7f7a6de97d@baylibre.com > > Changes in v3: > - rebase with master > > Changes in v2: > - Use imply instead of removing select altogether and dropped > patches 2/3 and 3/3 from previous series as using imply makes > them redundant > --- > arch/arm64/Kconfig.platforms | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 02007256709e..a6e4bfffc09d 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -133,8 +133,8 @@ config ARCH_K3 > select PM_GENERIC_DOMAINS if PM > select MAILBOX > select SOC_TI > - select TI_MESSAGE_MANAGER > - select TI_SCI_PROTOCOL > + imply TI_MESSAGE_MANAGER > + imply TI_SCI_PROTOCOL I really don't like "imply" in general, and this will be the only instance of it now in the whole file.. Your v1 of this series was the right way to do this IMHO. The only issue was patches 2/3 and 3/3 should have been first in the series to prevent bisect issues. And they had to go to two different maintainers so it shouldn't have been a single series in the first place. Andrew > select TI_K3_SOCINFO > help > This enables support for Texas Instruments' K3 multicore SoC > > --- > base-commit: 21266b8df5224c4f677acf9f353eecc9094731f0 > change-id: 20241016-timodulemailboxsci-412e2a6458fc > > Best regards,
Hi Andrew, thanks for review. Le 23/01/2025 à 16:29, Andrew Davis a écrit : > On 1/23/25 6:12 AM, Guillaume La Roque wrote: >> In order to build TI mailbox and TI SCI as modules, replace >> select with imply. >> >> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com> >> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> >> --- >> Changes in v4: >> - rebase on master branch >> - Link to v3: >> https://lore.kernel.org/r/20241016-timodulemailboxsci-v3-1-0e7f7a6de97d@baylibre.com >> >> Changes in v3: >> - rebase with master >> >> Changes in v2: >> - Use imply instead of removing select altogether and dropped >> patches 2/3 and 3/3 from previous series as using imply makes >> them redundant >> --- >> arch/arm64/Kconfig.platforms | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 02007256709e..a6e4bfffc09d 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -133,8 +133,8 @@ config ARCH_K3 >> select PM_GENERIC_DOMAINS if PM >> select MAILBOX >> select SOC_TI >> - select TI_MESSAGE_MANAGER >> - select TI_SCI_PROTOCOL >> + imply TI_MESSAGE_MANAGER >> + imply TI_SCI_PROTOCOL > > I really don't like "imply" in general, and this will be the only > instance of it now in the whole file.. > > Your v1 of this series was the right way to do this IMHO. The only > issue was patches 2/3 and 3/3 should have been first in the series to > prevent bisect issues. And they had to go to two different maintainers > so it shouldn't have been a single series in the first place. ok for me ,i will reuse v1 , split and resend. Thanks Guillaume > > Andrew > >> select TI_K3_SOCINFO >> help >> This enables support for Texas Instruments' K3 multicore SoC >> >> --- >> base-commit: 21266b8df5224c4f677acf9f353eecc9094731f0 >> change-id: 20241016-timodulemailboxsci-412e2a6458fc >> >> Best regards,
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 02007256709e..a6e4bfffc09d 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -133,8 +133,8 @@ config ARCH_K3 select PM_GENERIC_DOMAINS if PM select MAILBOX select SOC_TI - select TI_MESSAGE_MANAGER - select TI_SCI_PROTOCOL + imply TI_MESSAGE_MANAGER + imply TI_SCI_PROTOCOL select TI_K3_SOCINFO help This enables support for Texas Instruments' K3 multicore SoC