| Message ID | 20250122115120.2885015-1-claudiu.beznea.uj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | renesas: rzg3s: backport the RTC support | expand |
Hi Claudiu, Thanks for your patch. > -----Original Message----- > From: Claudiu <claudiu.beznea@tuxon.dev> > Sent: Wednesday, January 22, 2025 8:51 PM > To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de > Cc: claudiu.beznea@tuxon.dev; cip-dev@lists.cip-project.org > Subject: [PATCH v6.1.y-cip 00/14] renesas: rzg3s: backport the RTC support > > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Hi, > > Series backports the RTC support for the Renesas RZ/G3S SoC. > Along with a clock driver for the clock provided the VBATTB is included as this > is critical for the RTC to work, as it feeds the RTC counter. > > For the VBATTB clock driver the following patches were also > backported: > - clk: Add Sunplus SP7021 clock driver > - clk: fixed-factor: add fwname-based constructor functions > > and adjusted accordingly, if needed. > > Thank you, > Claudiu Beznea > > Claudiu Beznea (12): > clk: Add devm_clk_hw_register_gate_parent_hw() > clk: renesas: r9a08g045: Add clock, reset and power domain support for > the VBATTB IP > dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB > clk: renesas: vbattb: Add VBATTB clock driver > dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RTCA-3 IP > rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S > SoC > rtc: renesas-rtca3: Fix compilation error on RISC-V > arm64: dts: renesas: r9a08g045: Add VBATTB node > arm64: dts: renesas: rzg3s-smarc-som: Enable VBATTB > arm64: dts: renesas: r9a08g045: Add RTC node > arm64: dts: renesas: rzg3s-smarc-som: Enable RTC > arm64: defconfig: Enable VBATTB clock and Renesas RTCA-3 > > Qin Jian (1): > clk: Add Sunplus SP7021 clock driver > > Théo Lebrun (1): > clk: fixed-factor: add fwname-based constructor functions > I reviewed this and for 5.10.y-cip series, LGTM. But regarding "clk: Add Sunplus SP7021 clock driver", as I commented, I think we should consider it. Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/commits/ci/iwamatsu/linux-6.1.y-cip-rc https://gitlab.com/cip-project/cip-kernel/linux-cip/-/commits/ci/iwamatsu/linux-5.10.y-cip-rc Best regards, Nobuhiro
Hi, Nobuhiro, On 23.01.2025 07:44, Nobuhiro Iwamatsu via lists.cip-project.org wrote: > Hi Claudiu, > > Thanks for your patch. > >> -----Original Message----- >> From: Claudiu <claudiu.beznea@tuxon.dev> >> Sent: Wednesday, January 22, 2025 8:51 PM >> To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) >> <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de >> Cc: claudiu.beznea@tuxon.dev; cip-dev@lists.cip-project.org >> Subject: [PATCH v6.1.y-cip 00/14] renesas: rzg3s: backport the RTC support >> >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> Hi, >> >> Series backports the RTC support for the Renesas RZ/G3S SoC. >> Along with a clock driver for the clock provided the VBATTB is included as this >> is critical for the RTC to work, as it feeds the RTC counter. >> >> For the VBATTB clock driver the following patches were also >> backported: >> - clk: Add Sunplus SP7021 clock driver >> - clk: fixed-factor: add fwname-based constructor functions >> >> and adjusted accordingly, if needed. >> >> Thank you, >> Claudiu Beznea >> >> Claudiu Beznea (12): >> clk: Add devm_clk_hw_register_gate_parent_hw() >> clk: renesas: r9a08g045: Add clock, reset and power domain support for >> the VBATTB IP >> dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB >> clk: renesas: vbattb: Add VBATTB clock driver >> dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RTCA-3 IP >> rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S >> SoC >> rtc: renesas-rtca3: Fix compilation error on RISC-V >> arm64: dts: renesas: r9a08g045: Add VBATTB node >> arm64: dts: renesas: rzg3s-smarc-som: Enable VBATTB >> arm64: dts: renesas: r9a08g045: Add RTC node >> arm64: dts: renesas: rzg3s-smarc-som: Enable RTC >> arm64: defconfig: Enable VBATTB clock and Renesas RTCA-3 >> >> Qin Jian (1): >> clk: Add Sunplus SP7021 clock driver >> >> Théo Lebrun (1): >> clk: fixed-factor: add fwname-based constructor functions >> > > I reviewed this and for 5.10.y-cip series, LGTM. > But regarding "clk: Add Sunplus SP7021 clock driver", as I commented, I think we should consider it. For v5.10.y-cip only: this driver is selected by ARM/SUNPLUS SP7021 SOC. There is no SUNPLUS SP7021 SoC support in v5.10. With this, do you want me to backport the full patch (along with the fixes you mentioned) as well? Thank you, Claudiu > > Test: > https://gitlab.com/cip-project/cip-kernel/linux-cip/-/commits/ci/iwamatsu/linux-6.1.y-cip-rc > https://gitlab.com/cip-project/cip-kernel/linux-cip/-/commits/ci/iwamatsu/linux-5.10.y-cip-rc > > Best regards, > Nobuhiro > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17602): https://lists.cip-project.org/g/cip-dev/message/17602 > Mute This Topic: https://lists.cip-project.org/mt/110751142/8377987 > Group Owner: cip-dev+owner@lists.cip-project.org > Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/13165139/8377987/1773116124/xyzzy [claudiu.beznea@tuxon.dev] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Claudiu, > > I reviewed this and for 5.10.y-cip series, LGTM. > > But regarding "clk: Add Sunplus SP7021 clock driver", as I commented, I > think we should consider it. > > For v5.10.y-cip only: this driver is selected by ARM/SUNPLUS SP7021 SOC. > There is no SUNPLUS SP7021 SoC support in v5.10. With this, do you want me > to backport the full patch (along with the fixes you mentioned) as well? I didn't check 5.10.y. Thank you for checking. If you want to manage the same patch for 6.1.y-cip and 5.10.y-cip, Pavel's suggestion seems good. Would you consider this? Pavel’s comment: That would be one option. Another would be to apply just the include/linux/clk-provider.h with different title/changelog, explaining this adds only generic function and where it is originally from. Best regards, Nobuhiro
Hi, Nobuhiro, On 24.01.2025 07:56, Nobuhiro Iwamatsu via lists.cip-project.org wrote: > Hi Claudiu, > >>> I reviewed this and for 5.10.y-cip series, LGTM. >>> But regarding "clk: Add Sunplus SP7021 clock driver", as I commented, I >> think we should consider it. >> >> For v5.10.y-cip only: this driver is selected by ARM/SUNPLUS SP7021 SOC. >> There is no SUNPLUS SP7021 SoC support in v5.10. With this, do you want me >> to backport the full patch (along with the fixes you mentioned) as well? > > I didn't check 5.10.y. Thank you for checking. > If you want to manage the same patch for 6.1.y-cip and 5.10.y-cip, Pavel's suggestion seems good. > Would you consider this? Yes, I prefer going with Pavel's suggestion as it involves backporting less code. Thank you, Claudiu > > Pavel’s comment: > That would be one option. Another would be to apply just the > include/linux/clk-provider.h with different title/changelog, > explaining this adds only generic function and where it is originally > from. > > Best regards, > Nobuhiro > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17612): https://lists.cip-project.org/g/cip-dev/message/17612 > Mute This Topic: https://lists.cip-project.org/mt/110751142/8377987 > Group Owner: cip-dev+owner@lists.cip-project.org > Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/13165139/8377987/1773116124/xyzzy [claudiu.beznea@tuxon.dev] > -=-=-=-=-=-=-=-=-=-=-=- >
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Hi, Series backports the RTC support for the Renesas RZ/G3S SoC. Along with a clock driver for the clock provided the VBATTB is included as this is critical for the RTC to work, as it feeds the RTC counter. For the VBATTB clock driver the following patches were also backported: - clk: Add Sunplus SP7021 clock driver - clk: fixed-factor: add fwname-based constructor functions and adjusted accordingly, if needed. Thank you, Claudiu Beznea Claudiu Beznea (12): clk: Add devm_clk_hw_register_gate_parent_hw() clk: renesas: r9a08g045: Add clock, reset and power domain support for the VBATTB IP dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB clk: renesas: vbattb: Add VBATTB clock driver dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RTCA-3 IP rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S SoC rtc: renesas-rtca3: Fix compilation error on RISC-V arm64: dts: renesas: r9a08g045: Add VBATTB node arm64: dts: renesas: rzg3s-smarc-som: Enable VBATTB arm64: dts: renesas: r9a08g045: Add RTC node arm64: dts: renesas: rzg3s-smarc-som: Enable RTC arm64: defconfig: Enable VBATTB clock and Renesas RTCA-3 Qin Jian (1): clk: Add Sunplus SP7021 clock driver Théo Lebrun (1): clk: fixed-factor: add fwname-based constructor functions .../clock/renesas,r9a08g045-vbattb.yaml | 84 ++ .../bindings/rtc/renesas,rz-rtca3.yaml | 84 ++ MAINTAINERS | 8 + arch/arm64/boot/dts/renesas/r9a08g045.dtsi | 34 + .../boot/dts/renesas/rzg3s-smarc-som.dtsi | 16 + arch/arm64/configs/defconfig | 2 + drivers/clk/clk-fixed-factor.c | 59 +- drivers/clk/renesas/Kconfig | 5 + drivers/clk/renesas/Makefile | 1 + drivers/clk/renesas/clk-vbattb.c | 205 ++++ drivers/clk/renesas/r9a08g045-cpg.c | 3 + drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-renesas-rtca3.c | 902 ++++++++++++++++++ .../clock/renesas,r9a08g045-vbattb.h | 13 + include/linux/clk-provider.h | 43 + 16 files changed, 1456 insertions(+), 14 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/renesas,r9a08g045-vbattb.yaml create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rz-rtca3.yaml create mode 100644 drivers/clk/renesas/clk-vbattb.c create mode 100644 drivers/rtc/rtc-renesas-rtca3.c create mode 100644 include/dt-bindings/clock/renesas,r9a08g045-vbattb.h