| Message ID | 20250123-fuse-uring-for-6-14-incremental-to-v10-v1-0-8aee9f27c066@ddn.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fuse: over-io-uring fixes | expand |
Hi Bernd, On Thu, Jan 23 2025, Bernd Schubert wrote: > This is a list of fixes that came up from review of Luis > and smatch run from Dan. > I didn't put in commit id in the "Fixes:" line, as it is > fuse-io-uring is in linux next only and might get rebases > with new IDs. Thank you for this, Bernd. And sorry for the extra work -- I should have sent these patches myself instead of simply sending review comments. :-( Anyway, they all look good, and probably they should simply be squashed into the respective patches they are fixing. If they are kept separately, feel free to add my Reviewed-by: Luis Henriques <luis@igalia.com> Cheers,
On Fri, 24 Jan 2025 at 10:00, Luis Henriques <luis@igalia.com> wrote: > Anyway, they all look good, and probably they should simply be squashed > into the respective patches they are fixing. If they are kept separately, > feel free to add my I folded these fixes, except the enable_uring fix, which has no obvious target. > Reviewed-by: Luis Henriques <luis@igalia.com> Luis, you seem to have done a though review of the patches (thank you!) May I add your RVB to the complete patchset? Thanks, Miklos
On Fri, Jan 24 2025, Miklos Szeredi wrote: > On Fri, 24 Jan 2025 at 10:00, Luis Henriques <luis@igalia.com> wrote: > >> Anyway, they all look good, and probably they should simply be squashed >> into the respective patches they are fixing. If they are kept separately, >> feel free to add my > > I folded these fixes, except the enable_uring fix, which has no obvious target. > >> Reviewed-by: Luis Henriques <luis@igalia.com> > > Luis, you seem to have done a though review of the patches (thank > you!) May I add your RVB to the complete patchset? Yes, sure. Feel free to add it to the whole series, thanks. Cheers,
On 1/24/25 11:25, Miklos Szeredi wrote: > On Fri, 24 Jan 2025 at 10:00, Luis Henriques <luis@igalia.com> wrote: > >> Anyway, they all look good, and probably they should simply be squashed >> into the respective patches they are fixing. If they are kept separately, >> feel free to add my > > I folded these fixes, except the enable_uring fix, which has no obvious target. > >> Reviewed-by: Luis Henriques <luis@igalia.com> > > Luis, you seem to have done a though review of the patches (thank > you!) May I add your RVB to the complete patchset? Definitely big "Thanks" Luis! And sorry for all the extra work Miklos (and also your reviews). Maybe you could add to the "enable_uring" fix a "Reported-by: Luis Henriques <luis@igalia.com>" (sorry, should have done that in the first place). Thanks, Bernd
On Fri, Jan 24, 2025 at 1:00 AM Luis Henriques <luis@igalia.com> wrote: > > Hi Bernd, > > On Thu, Jan 23 2025, Bernd Schubert wrote: > > > This is a list of fixes that came up from review of Luis > > and smatch run from Dan. > > I didn't put in commit id in the "Fixes:" line, as it is > > fuse-io-uring is in linux next only and might get rebases > > with new IDs. > > Thank you for this, Bernd. And sorry for the extra work -- I should have > sent these patches myself instead of simply sending review comments. :-( Sorry for the delay, I haven't gotten to looking at the latter io-uring patches (10 to 17) yet in v10. If there are any minor fixes, Bernd do you prefer that we send review comments or that we send patches on top of the for-next tree? Thanks for your hard work on this io-uring series. Thanks, Joanne > > Anyway, they all look good, and probably they should simply be squashed > into the respective patches they are fixing. If they are kept separately, > feel free to add my > > Reviewed-by: Luis Henriques <luis@igalia.com> > > Cheers, > -- > Luís > > > Signed-off-by: Bernd Schubert <bschubert@ddn.com> > > --- > > Bernd Schubert (5): > > fuse: Fix copy_from_user error return code in fuse_uring_commit > > fuse: Remove an err= assignment and move a comment > > fuse: prevent disabling io-uring on active connections > > fuse: Remove unneeded include in fuse_dev_i.h > > fuse: Fix the struct fuse_args->in_args array size > > > > fs/fuse/dev_uring.c | 23 ++++++++++++----------- > > fs/fuse/fuse_dev_i.h | 1 - > > fs/fuse/fuse_i.h | 2 +- > > 3 files changed, 13 insertions(+), 13 deletions(-) > > --- > > base-commit: a5ca7ba2e604b5d4eb54e1e2746851fdd5d9e98f > > change-id: 20250123-fuse-uring-for-6-14-incremental-to-v10-b6b916b77720 > > > > Best regards, > > -- > > Bernd Schubert <bschubert@ddn.com> > >
On 1/24/25 19:56, Joanne Koong wrote: > On Fri, Jan 24, 2025 at 1:00 AM Luis Henriques <luis@igalia.com> wrote: >> >> Hi Bernd, >> >> On Thu, Jan 23 2025, Bernd Schubert wrote: >> >>> This is a list of fixes that came up from review of Luis >>> and smatch run from Dan. >>> I didn't put in commit id in the "Fixes:" line, as it is >>> fuse-io-uring is in linux next only and might get rebases >>> with new IDs. >> >> Thank you for this, Bernd. And sorry for the extra work -- I should have >> sent these patches myself instead of simply sending review comments. :-( > > Sorry for the delay, I haven't gotten to looking at the latter > io-uring patches (10 to 17) yet in v10. > If there are any minor fixes, Bernd do you prefer that we send review > comments or that we send patches on top of the for-next tree? Thanks > for your hard work on this io-uring series. Either way is fine. And thanks for all your reviews! Cheersm Bernd
This is a list of fixes that came up from review of Luis and smatch run from Dan. I didn't put in commit id in the "Fixes:" line, as it is fuse-io-uring is in linux next only and might get rebases with new IDs. Signed-off-by: Bernd Schubert <bschubert@ddn.com> --- Bernd Schubert (5): fuse: Fix copy_from_user error return code in fuse_uring_commit fuse: Remove an err= assignment and move a comment fuse: prevent disabling io-uring on active connections fuse: Remove unneeded include in fuse_dev_i.h fuse: Fix the struct fuse_args->in_args array size fs/fuse/dev_uring.c | 23 ++++++++++++----------- fs/fuse/fuse_dev_i.h | 1 - fs/fuse/fuse_i.h | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) --- base-commit: a5ca7ba2e604b5d4eb54e1e2746851fdd5d9e98f change-id: 20250123-fuse-uring-for-6-14-incremental-to-v10-b6b916b77720 Best regards,