| Message ID | 20250123194208.2660-1-tanyaagarwal25699@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | landlock: fix grammar and spelling error | expand |
On Fri, Jan 24, 2025 at 01:12:10AM +0530, Tanya Agarwal wrote: > From: Tanya Agarwal <tanyaagarwal25699@gmail.com> > > Fix grammar and spelling error in landlock module comments that were > identified using the codespell tool. > No functional changes - documentation only. > > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> > --- > Original discussion: > https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com > > This patch set is split into individual patches for each LSM > to facilitate easier review by respective maintainers. > > security/landlock/ruleset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c > index a93bdbf52fff..c464d1f84792 100644 > --- a/security/landlock/ruleset.c > +++ b/security/landlock/ruleset.c > @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id, > return ERR_PTR(-ENOMEM); > RB_CLEAR_NODE(&new_rule->node); > if (is_object_pointer(id.type)) { > - /* This should be catched by insert_rule(). */ > + /* This should have been caught by insert_rule(). */ > WARN_ON_ONCE(!id.key.object); > landlock_get_object(id.key.object); > } > -- > 2.39.5 > Reviewed-by: Günther Noack <gnoack@google.com> Thanks! —Günther
On Fri, Jan 24, 2025 at 01:12:10AM +0530, Tanya Agarwal wrote: > From: Tanya Agarwal <tanyaagarwal25699@gmail.com> > > Fix grammar and spelling error in landlock module comments that were > identified using the codespell tool. > No functional changes - documentation only. > > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> I think Mimi's tag was for the IMA part, so I'll remove it. > --- > Original discussion: > https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com > > This patch set is split into individual patches for each LSM > to facilitate easier review by respective maintainers. > > security/landlock/ruleset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c > index a93bdbf52fff..c464d1f84792 100644 > --- a/security/landlock/ruleset.c > +++ b/security/landlock/ruleset.c > @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id, > return ERR_PTR(-ENOMEM); > RB_CLEAR_NODE(&new_rule->node); > if (is_object_pointer(id.type)) { > - /* This should be catched by insert_rule(). */ > + /* This should have been caught by insert_rule(). */ > WARN_ON_ONCE(!id.key.object); > landlock_get_object(id.key.object); > } Thanks, I'll take it in my tree.
On Fri, Jan 24, 2025 at 5:06 PM Mickaël Salaün <mic@digikod.net> wrote: > > On Fri, Jan 24, 2025 at 01:12:10AM +0530, Tanya Agarwal wrote: > > From: Tanya Agarwal <tanyaagarwal25699@gmail.com> > > > > Fix grammar and spelling error in landlock module comments that were > > identified using the codespell tool. > > No functional changes - documentation only. > > > > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com> > > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> > > I think Mimi's tag was for the IMA part, so I'll remove it. > > > --- > > Original discussion: > > https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com > > > > This patch set is split into individual patches for each LSM > > to facilitate easier review by respective maintainers. > > > > security/landlock/ruleset.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c > > index a93bdbf52fff..c464d1f84792 100644 > > --- a/security/landlock/ruleset.c > > +++ b/security/landlock/ruleset.c > > @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id, > > return ERR_PTR(-ENOMEM); > > RB_CLEAR_NODE(&new_rule->node); > > if (is_object_pointer(id.type)) { > > - /* This should be catched by insert_rule(). */ > > + /* This should have been caught by insert_rule(). */ > > WARN_ON_ONCE(!id.key.object); > > landlock_get_object(id.key.object); > > } > > Thanks, I'll take it in my tree. Thanks Mickael. Regards, Tanya
diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c index a93bdbf52fff..c464d1f84792 100644 --- a/security/landlock/ruleset.c +++ b/security/landlock/ruleset.c @@ -121,7 +121,7 @@ create_rule(const struct landlock_id id, return ERR_PTR(-ENOMEM); RB_CLEAR_NODE(&new_rule->node); if (is_object_pointer(id.type)) { - /* This should be catched by insert_rule(). */ + /* This should have been caught by insert_rule(). */ WARN_ON_ONCE(!id.key.object); landlock_get_object(id.key.object); }