[v2,24/24] cpus: Remove CPUClass::has_work() handler

Commit Message

Philippe Mathieu-Daudé Jan. 25, 2025, 4:05 p.m. UTC

All handlers have been converted to SysemuCPUOps::has_work().
Remove CPUClass::has_work along with cpu_common_has_work()
and simplify cpu_has_work(), making SysemuCPUOps::has_work
handler mandatory.

Reviewed-by: Richard Henderson <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
 include/hw/core/cpu.h            | 2 --
 include/hw/core/sysemu-cpu-ops.h | 2 +-
 cpu-target.c                     | 4 ++++
 hw/core/cpu-common.c             | 6 ------
 hw/core/cpu-system.c             | 7 +------
 5 files changed, 6 insertions(+), 15 deletions(-)

Comments

Philippe Mathieu-Daudé Jan. 25, 2025, 4:15 p.m. UTC | #1

On 25/1/25 17:05, Philippe Mathieu-Daudé wrote:
> All handlers have been converted to SysemuCPUOps::has_work().
> Remove CPUClass::has_work along with cpu_common_has_work()
> and simplify cpu_has_work(), making SysemuCPUOps::has_work
> handler mandatory.
> 
> Reviewed-by: Richard Henderson <[e-mail]>
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
>   include/hw/core/cpu.h            | 2 --
>   include/hw/core/sysemu-cpu-ops.h | 2 +-
>   cpu-target.c                     | 4 ++++
>   hw/core/cpu-common.c             | 6 ------
>   hw/core/cpu-system.c             | 7 +------
>   5 files changed, 6 insertions(+), 15 deletions(-)


> diff --git a/cpu-target.c b/cpu-target.c
> index 98e9e7cc4a1..15aa8afef55 100644
> --- a/cpu-target.c
> +++ b/cpu-target.c
> @@ -217,6 +217,10 @@ void cpu_class_init_props(DeviceClass *dc)
>   {
>   #ifndef CONFIG_USER_ONLY
>       ObjectClass *oc = OBJECT_CLASS(dc);
> +    const CPUClass *cc = CPU_CLASS(OBJECT_CLASS(oc));
> +
> +    /* Check mandatory SysemuCPUOps handlers */
> +    g_assert(cc->sysemu_ops->has_work);

Thinking about it again, this function is about properties, thus
this isn't the correct place to do that check. I'll revisit.

>   
>       /*
>        * We can't use DEFINE_PROP_BOOL in the Property array for this

Patch

diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index d64c823e768..2bcad4b16bf 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -104,7 +104,6 @@  struct SysemuCPUOps;
  *                 instantiatable CPU type.
  * @parse_features: Callback to parse command line arguments.
  * @reset_dump_flags: #CPUDumpFlags to use for reset logging.
- * @has_work: Callback for checking if there is work to do.
  * @mmu_index: Callback for choosing softmmu mmu index;
  *       may be used internally by memory_rw_debug without TCG.
  * @memory_rw_debug: Callback for GDB memory access.
@@ -151,7 +150,6 @@  struct CPUClass {
     ObjectClass *(*class_by_name)(const char *cpu_model);
     void (*parse_features)(const char *typename, char *str, Error **errp);
 
-    bool (*has_work)(CPUState *cpu);
     int (*mmu_index)(CPUState *cpu, bool ifetch);
     int (*memory_rw_debug)(CPUState *cpu, vaddr addr,
                            uint8_t *buf, int len, bool is_write);
diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h
index dee8a62ca98..877892373f9 100644
--- a/include/hw/core/sysemu-cpu-ops.h
+++ b/include/hw/core/sysemu-cpu-ops.h
@@ -19,7 +19,7 @@  typedef struct SysemuCPUOps {
     /**
      * @has_work: Callback for checking if there is work to do.
      */
-    bool (*has_work)(CPUState *cpu);
+    bool (*has_work)(CPUState *cpu); /* MANDATORY NON-NULL */
     /**
      * @get_memory_mapping: Callback for obtaining the memory mappings.
      */
diff --git a/cpu-target.c b/cpu-target.c
index 98e9e7cc4a1..15aa8afef55 100644
--- a/cpu-target.c
+++ b/cpu-target.c
@@ -217,6 +217,10 @@  void cpu_class_init_props(DeviceClass *dc)
 {
 #ifndef CONFIG_USER_ONLY
     ObjectClass *oc = OBJECT_CLASS(dc);
+    const CPUClass *cc = CPU_CLASS(OBJECT_CLASS(oc));
+
+    /* Check mandatory SysemuCPUOps handlers */
+    g_assert(cc->sysemu_ops->has_work);
 
     /*
      * We can't use DEFINE_PROP_BOOL in the Property array for this
diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
index 886aa793c04..c933de1416c 100644
--- a/hw/core/cpu-common.c
+++ b/hw/core/cpu-common.c
@@ -134,11 +134,6 @@  static void cpu_common_reset_hold(Object *obj, ResetType type)
     cpu_exec_reset_hold(cpu);
 }
 
-static bool cpu_common_has_work(CPUState *cs)
-{
-    return false;
-}
-
 ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model)
 {
     ObjectClass *oc;
@@ -304,7 +299,6 @@  static void cpu_common_class_init(ObjectClass *klass, void *data)
 
     k->parse_features = cpu_common_parse_features;
     k->get_arch_id = cpu_common_get_arch_id;
-    k->has_work = cpu_common_has_work;
     k->gdb_read_register = cpu_common_gdb_read_register;
     k->gdb_write_register = cpu_common_gdb_write_register;
     set_bit(DEVICE_CATEGORY_CPU, dc->categories);
diff --git a/hw/core/cpu-system.c b/hw/core/cpu-system.c
index 7b16bda2250..32d09757169 100644
--- a/hw/core/cpu-system.c
+++ b/hw/core/cpu-system.c
@@ -25,12 +25,7 @@ 
 
 bool cpu_has_work(CPUState *cpu)
 {
-    if (cpu->cc->sysemu_ops->has_work) {
-        return cpu->cc->sysemu_ops->has_work(cpu);
-    }
-
-    g_assert(cpu->cc->has_work);
-    return cpu->cc->has_work(cpu);
+    return cpu->cc->sysemu_ops->has_work(cpu);
 }
 
 bool cpu_paging_enabled(const CPUState *cpu)