| Message ID | 20250129171842.1588526-1-alexeymin@postmarketos.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] clk: qcom: gcc-sdm660: Add missing SDCC block resets | expand |
On 29/01/2025 18:18, Alexey Minnekhanov wrote: > This will allow linux to properly reset eMMC/SD blocks. > > Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660") > No line breaks between tags (see `git log`). > Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> > --- > include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++ That's a separate patch. Always. Best regards, Krzysztof
On 1/29/25 10:06 PM, Krzysztof Kozlowski wrote: > > No line breaks between tags (see `git log`). > Will fix in v2. > >> include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++ > > That's a separate patch. Always. > No big deal, but I've looked at git log and found previous commit b538304da785 ("clk: qcom: gcc-sdm660: Add missing modem reset") [1] that did similar things, but in a single patch, so I did the same. Will fix in v2. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b538304da7855f4e31f91f915f259936eb67a1e6 -- Regards, Alexey
On 29/01/2025 21:52, Alexey Minnekhanov wrote: > On 1/29/25 10:06 PM, Krzysztof Kozlowski wrote: >> >> No line breaks between tags (see `git log`). >> > > Will fix in v2. > >> >>> include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++ >> >> That's a separate patch. Always. >> > > No big deal, but I've looked at git log and found previous commit > b538304da785 ("clk: qcom: gcc-sdm660: Add missing modem reset") [1] that > did similar things, but in a single patch, so I did the same. > > Will fix in v2. Is there DT Ack for that commit? No. You also marked this commit as fixes, so explain in commit msg user-observable bug being fixed here. Best regards, Krzysztof
diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c index df79298a1a25..1856a2d96dde 100644 --- a/drivers/clk/qcom/gcc-sdm660.c +++ b/drivers/clk/qcom/gcc-sdm660.c @@ -2420,6 +2420,8 @@ static struct gdsc *gcc_sdm660_gdscs[] = { static const struct qcom_reset_map gcc_sdm660_resets[] = { [GCC_QUSB2PHY_PRIM_BCR] = { 0x12000 }, [GCC_QUSB2PHY_SEC_BCR] = { 0x12004 }, + [GCC_SDCC1_BCR] = { 0x16000 }, + [GCC_SDCC2_BCR] = { 0x14000 }, [GCC_UFS_BCR] = { 0x75000 }, [GCC_USB3_DP_PHY_BCR] = { 0x50028 }, [GCC_USB3_PHY_BCR] = { 0x50020 }, diff --git a/include/dt-bindings/clock/qcom,gcc-sdm660.h b/include/dt-bindings/clock/qcom,gcc-sdm660.h index df8a6f3d367e..74c22f67da21 100644 --- a/include/dt-bindings/clock/qcom,gcc-sdm660.h +++ b/include/dt-bindings/clock/qcom,gcc-sdm660.h @@ -153,5 +153,7 @@ #define GCC_USB_30_BCR 7 #define GCC_USB_PHY_CFG_AHB2PHY_BCR 8 #define GCC_MSS_RESTART 9 +#define GCC_SDCC1_BCR 10 +#define GCC_SDCC2_BCR 11 #endif
This will allow linux to properly reset eMMC/SD blocks. Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660") Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> --- drivers/clk/qcom/gcc-sdm660.c | 2 ++ include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++ 2 files changed, 4 insertions(+)