| Message ID | 20250113-jag-bringup_fixes-v1-12-fb28030b1f26@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kdevops: Various fixes | expand |
On Mon, Jan 13, 2025 at 12:53:10PM +0100, Joel Granados wrote: > Signed-off-by: Joel Granados <joel.granados@kernel.org> > --- > scripts/guestfs.Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile > index 480bc4f..f463ecc 100644 > --- a/scripts/guestfs.Makefile > +++ b/scripts/guestfs.Makefile > @@ -77,6 +77,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) > --inventory localhost, \ > playbooks/bringup_guestfs.yml \ > -e 'ansible_python_interpreter=/usr/bin/python3' \ > + -e 'running_user=$(USER)' \ Why is this change needed? A commit message explaining it would be good. I see running_user was added for libvirt_user.yml to replace ansible_user. Maybe we don't need any of the running_user variables if we use ansible_user_id instead. > --extra-vars=@./extra_vars.yaml \ > --tags config-check,network,build-deps > $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh > > -- > 2.44.2 > >
On Thu, Jan 30, 2025 at 09:06:52AM +0100, Daniel Gomez wrote: > On Mon, Jan 13, 2025 at 12:53:10PM +0100, Joel Granados wrote: > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > --- > > scripts/guestfs.Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile > > index 480bc4f..f463ecc 100644 > > --- a/scripts/guestfs.Makefile > > +++ b/scripts/guestfs.Makefile > > @@ -77,6 +77,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) > > --inventory localhost, \ > > playbooks/bringup_guestfs.yml \ > > -e 'ansible_python_interpreter=/usr/bin/python3' \ > > + -e 'running_user=$(USER)' \ > > Why is this change needed? sigh. I can't remember. I should have added a comment. Lets drop this one for now. until I remember at least. > > A commit message explaining it would be good. > > I see running_user was added for libvirt_user.yml to replace > ansible_user. Maybe we don't need any of the running_user variables if > we use ansible_user_id instead. > > > --extra-vars=@./extra_vars.yaml \ > > --tags config-check,network,build-deps > > $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh > > > > -- > > 2.44.2 > > > >
diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index 480bc4f..f463ecc 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -77,6 +77,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) --inventory localhost, \ playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ + -e 'running_user=$(USER)' \ --extra-vars=@./extra_vars.yaml \ --tags config-check,network,build-deps $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh
Signed-off-by: Joel Granados <joel.granados@kernel.org> --- scripts/guestfs.Makefile | 1 + 1 file changed, 1 insertion(+)