| Message ID | 20250128-fix_tsconfig-v1-1-87adcdc4e394@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ethtool: timestamping: Fix small issues in the new uAPI | expand |
On Tue, 28 Jan 2025 16:35:46 +0100 Kory Maincent wrote: > Add myself as maintainer for socket timestamping. I have contributed > modifications to the timestamping core to support selection between > multiple PTP instances within a network topology. > > Expand the file list to include timestamping ethtool support. Hi Kory, is there more context you could provide for this change? For core pieces of the stack, with a long history, we tend to designate as maintainer folks who review the changes, not just write code. According to our development stats that doesn't describe you, just yet: Top reviewer score: 6.12: Negative # 5 ( +6) [ 50] Kory Maincent (Dent Project) 6.13: Negative #11 (***) [ 29] Kory Maincent (Dent Project) https://lore.kernel.org/20250121200710.19126f7d@kernel.org https://lore.kernel.org/20241119191608.514ea226@kernel.org https://lore.kernel.org/20240922190125.24697d06@kernel.org That said, I do feel like we're lacking maintainers for sections of the ethtool code. Maybe we could start with adding and entry for you for just: > +F: net/ethtool/tsconfig.c > +F: net/ethtool/tsinfo.c Does that sound fair?
On Wed, 29 Jan 2025 16:39:16 -0800 Jakub Kicinski <kuba@kernel.org> wrote: > On Tue, 28 Jan 2025 16:35:46 +0100 Kory Maincent wrote: > > Add myself as maintainer for socket timestamping. I have contributed > > modifications to the timestamping core to support selection between > > multiple PTP instances within a network topology. > > > > Expand the file list to include timestamping ethtool support. > > Hi Kory, is there more context you could provide for this change? > > For core pieces of the stack, with a long history, we tend to > designate as maintainer folks who review the changes, not just > write code. According to our development stats that doesn't > describe you, just yet: > > Top reviewer score: > > 6.12: Negative # 5 ( +6) [ 50] Kory Maincent (Dent Project) > 6.13: Negative #11 (***) [ 29] Kory Maincent (Dent Project) Yes indeed, I am not really confident reviewing code part that I don't know well. My thought that I did not have lots on review in the PTP patch series I just managed to get merged. So I would try to change that. Moreover I have changed a bit the management of time stamping configuration so if there is changes or fixes I could be helpful. Indeed adding myself as maintainer is a bit overestimated, maybe I could be set as a reviewer to be in the CC of the patches. > https://lore.kernel.org/20250121200710.19126f7d@kernel.org > https://lore.kernel.org/20241119191608.514ea226@kernel.org > https://lore.kernel.org/20240922190125.24697d06@kernel.org > > That said, I do feel like we're lacking maintainers for sections > of the ethtool code. Maybe we could start with adding and entry > for you for just: > > > +F: net/ethtool/tsconfig.c > > +F: net/ethtool/tsinfo.c > > Does that sound fair? Yes it does. Whether setting me as reviewer for the SOCKET TIMESTAMPING subpart or adding me as maintainer of these two files it is ok for me. What do you prefer? I will try to review more ethtool code now that I began to understand how it works thanks to my PoE and PTP work. Regards,
On Thu, 30 Jan 2025 10:18:11 +0100 Kory Maincent wrote: > > > +F: net/ethtool/tsconfig.c > > > +F: net/ethtool/tsinfo.c > > > > Does that sound fair? > > Yes it does. Whether setting me as reviewer for the SOCKET TIMESTAMPING subpart > or adding me as maintainer of these two files it is ok for me. What do you > prefer? The latter, TBH. I'll send the patch. We recommend setting up lore+lei to subscribe to threads which touch particular files. It's much more scalable than adding interested folks to MAINTAINERS. Tho, last time I looked lei didn't support the weird mdir format used by claws :(
On Thu, 30 Jan 2025 08:31:04 -0800 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 30 Jan 2025 10:18:11 +0100 Kory Maincent wrote: > [...] > > > > > > Does that sound fair? > > > > Yes it does. Whether setting me as reviewer for the SOCKET TIMESTAMPING > > subpart or adding me as maintainer of these two files it is ok for me. What > > do you prefer? > > The latter, TBH. I'll send the patch. We recommend setting up lore+lei > to subscribe to threads which touch particular files. It's much more > scalable than adding interested folks to MAINTAINERS. Tho, last time > I looked lei didn't support the weird mdir format used by claws :( You are right don't bother to add me to MAINTAINERS file, I am indeed not an experienced reviewer for now. Oh, didn't know the lei tools. Thanks! Regards,
diff --git a/MAINTAINERS b/MAINTAINERS index 1899ef93e498..1052131a141d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21729,10 +21729,14 @@ F: sound/soc/uniphier/ SOCKET TIMESTAMPING M: Willem de Bruijn <willemdebruijn.kernel@gmail.com> +M: Kory Maincent <kory.maincent@bootlin.com> S: Maintained F: Documentation/networking/timestamping.rst F: include/linux/net_tstamp.h F: include/uapi/linux/net_tstamp.h +F: net/core/timestamping.c +F: net/ethtool/tsconfig.c +F: net/ethtool/tsinfo.c F: tools/testing/selftests/net/so_txtime.c SOEKRIS NET48XX LED SUPPORT
Add myself as maintainer for socket timestamping. I have contributed modifications to the timestamping core to support selection between multiple PTP instances within a network topology. Expand the file list to include timestamping ethtool support. Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- MAINTAINERS | 4 ++++ 1 file changed, 4 insertions(+)