diff mbox series

[4/6] accel/ivpu: Turn on HWS by default on all platforms

Message ID 20250129125636.1047413-5-jacek.lawrynowicz@linux.intel.com (mailing list archive)
State New
Headers show
Series accel/ivpu: Changes for 6.15 | expand

Commit Message

Jacek Lawrynowicz Jan. 29, 2025, 12:56 p.m. UTC 
From: Karol Wachowski <karol.wachowski@intel.com>

Hardware scheduling (HWS) is supposed to be supported on all existing
platform with recent FW including pre-silicon ones. Turn on HWS by
default.

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Signed-off-by: Karol Wachowski <karol.wachowski@intel.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
---
 drivers/accel/ivpu/ivpu_fw.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Jeffrey Hugo Jan. 31, 2025, 6:47 p.m. UTC | #1 
On 1/29/2025 5:56 AM, Jacek Lawrynowicz wrote:
> From: Karol Wachowski <karol.wachowski@intel.com>
> 
> Hardware scheduling (HWS) is supposed to be supported on all existing
> platform with recent FW including pre-silicon ones. Turn on HWS by
> default.

Is there released firmware which does not have this enabled/supported? 
Should this be a "on by default, if FW VER > X"?

-Jeff
Jacek Lawrynowicz Feb. 3, 2025, 9:26 a.m. UTC | #2 
Yes and there is a check for FW version in ivpu_fw_sched_mode_select() that verifies this.
It is just above the changed lines from this patch.

On 1/31/2025 7:47 PM, Jeffrey Hugo wrote:
> On 1/29/2025 5:56 AM, Jacek Lawrynowicz wrote:
>> From: Karol Wachowski <karol.wachowski@intel.com>
>>
>> Hardware scheduling (HWS) is supposed to be supported on all existing
>> platform with recent FW including pre-silicon ones. Turn on HWS by
>> default.
> 
> Is there released firmware which does not have this enabled/supported? Should this be a "on by default, if FW VER > X"?
> 
> -Jeff
diff mbox series

Patch

diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
index 6cf1fb826d1ba..cfe8f79ec5a6f 100644
--- a/drivers/accel/ivpu/ivpu_fw.c
+++ b/drivers/accel/ivpu/ivpu_fw.c
@@ -148,15 +148,7 @@  ivpu_fw_sched_mode_select(struct ivpu_device *vdev, const struct vpu_firmware_he
 	if (IVPU_FW_CHECK_API_VER_LT(vdev, fw_hdr, JSM, 3, 24))
 		return VPU_SCHEDULING_MODE_OS;
 
-	switch (ivpu_device_id(vdev)) {
-	case PCI_DEVICE_ID_MTL:
-	case PCI_DEVICE_ID_ARL:
-	case PCI_DEVICE_ID_LNL:
-	case PCI_DEVICE_ID_PTL_P:
-		return VPU_SCHEDULING_MODE_HW;
-	default:
-		return VPU_SCHEDULING_MODE_OS;
-	}
+	return VPU_SCHEDULING_MODE_HW;
 }
 
 static int ivpu_fw_parse(struct ivpu_device *vdev)