diff mbox series

[v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC.

Message ID 20250201-pcie-en7581-remove-mac_reset-v2-1-a06786cdc683@kernel.org (mailing list archive)
State New
Headers show
Series [v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC. | expand

Commit Message

Lorenzo Bianconi Feb. 1, 2025, 11 a.m. UTC
Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
This is not harmful since EN7581 does not requires mac_reset and
mac_reset is not defined in EN7581 device tree.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
Changes in v2:
- fix typo in commit log
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 1 -
 1 file changed, 1 deletion(-)


---
base-commit: 647d69605c70368d54fc012fce8a43e8e5955b04
change-id: 20250201-pcie-en7581-remove-mac_reset-16e7b6e3ef06

Best regards,

Comments

Philipp Zabel Feb. 1, 2025, 11:50 a.m. UTC | #1
On Sat, Feb 01, 2025 at 12:00:18PM +0100, Lorenzo Bianconi wrote:
> Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
> This is not harmful since EN7581 does not requires mac_reset and
> mac_reset is not defined in EN7581 device tree.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp
diff mbox series

Patch

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index aa24ac9aaecc749b53cfc4faf6399913d20cdbf2..0f64e76e2111468e6a453889ead7fbc75804faf7 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -940,7 +940,6 @@  static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
 	 */
 	reset_control_bulk_assert(pcie->soc->phy_resets.num_resets,
 				  pcie->phy_resets);
-	reset_control_assert(pcie->mac_reset);
 
 	/* Wait for the time needed to complete the reset lines assert. */
 	msleep(PCIE_EN7581_RESET_TIME_MS);