diff mbox series

[13/13] ASoC: adau1701: use gpiods_set_array_value_cansleep

Message ID 20250131-gpio-set-array-helper-v1-13-991c8ccb4d6e@baylibre.com (mailing list archive)
State Changes Requested
Headers show
Series gpiolib: add gpiods_set_array_value_cansleep | expand

Commit Message

David Lechner Jan. 31, 2025, 8:24 p.m. UTC 
Reduce verbosity by using gpiods_set_array_value_cansleep() instead of
gpiods_set_array_value_cansleep().

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 sound/soc/codecs/adau1701.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Andy Shevchenko Feb. 2, 2025, 10:24 a.m. UTC | #1 
On Fri, Jan 31, 2025 at 10:25 PM David Lechner <dlechner@baylibre.com> wrote:
>
> Reduce verbosity by using gpiods_set_array_value_cansleep() instead of
> gpiods_set_array_value_cansleep().

...

>                         __assign_bit(1, values, 1);

Seems like an interesting way to say __set_bit().
Mark Brown Feb. 3, 2025, 12:24 p.m. UTC | #2 
On Fri, Jan 31, 2025 at 02:24:53PM -0600, David Lechner wrote:
> Reduce verbosity by using gpiods_set_array_value_cansleep() instead of
> gpiods_set_array_value_cansleep().

Acked-by: Mark Brown <broonie@kernel.org>
diff mbox series

Patch

diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
index 291249e0a2a32df7dde81904dce2f6be143fc2d7..d3e6b2763950f78143c0feb07c36764cb265441a 100644
--- a/sound/soc/codecs/adau1701.c
+++ b/sound/soc/codecs/adau1701.c
@@ -325,9 +325,7 @@  static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd
 			__assign_bit(1, values, 1);
 			break;
 		}
-		gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs,
-				adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info,
-				values);
+		gpiods_set_array_value_cansleep(adau1701->gpio_pll_mode, values);
 	}
 
 	adau1701->pll_clkdiv = clkdiv;