diff mbox series

[v3,20/20] ASoC: uniphier: use devm_kmemdup_array()

Message ID 20250203080902.1864382-21-raag.jadav@intel.com (mailing list archive)
State New
Headers show
Series Split devres APIs to device/devres.h and introduce devm_kmemdup_array() | expand

Commit Message

Raag Jadav Feb. 3, 2025, 8:09 a.m. UTC 
Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 sound/soc/uniphier/aio-cpu.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Andy Shevchenko Feb. 3, 2025, 9:53 a.m. UTC | #1 
On Mon, Feb 03, 2025 at 01:39:02PM +0530, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.

...

>  	chip->num_plls = chip->chip_spec->num_plls;
> -	chip->plls = devm_kcalloc(dev,
> -				  chip->num_plls,
> -				  sizeof(struct uniphier_aio_pll),
> -				  GFP_KERNEL);
> +	chip->plls = devm_kmemdup_array(dev, chip->chip_spec->plls, chip->num_plls,
> +					sizeof(struct uniphier_aio_pll), GFP_KERNEL);

sizeof(*chip->plls) ?

>  	if (!chip->plls)
>  		return -ENOMEM;
diff mbox series

Patch

diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c
index 470f129166a4..44f4053e5584 100644
--- a/sound/soc/uniphier/aio-cpu.c
+++ b/sound/soc/uniphier/aio-cpu.c
@@ -762,14 +762,10 @@  int uniphier_aio_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	chip->num_plls = chip->chip_spec->num_plls;
-	chip->plls = devm_kcalloc(dev,
-				  chip->num_plls,
-				  sizeof(struct uniphier_aio_pll),
-				  GFP_KERNEL);
+	chip->plls = devm_kmemdup_array(dev, chip->chip_spec->plls, chip->num_plls,
+					sizeof(struct uniphier_aio_pll), GFP_KERNEL);
 	if (!chip->plls)
 		return -ENOMEM;
-	memcpy(chip->plls, chip->chip_spec->plls,
-	       sizeof(struct uniphier_aio_pll) * chip->num_plls);
 
 	for (i = 0; i < chip->num_aios; i++) {
 		struct uniphier_aio *aio = &chip->aios[i];