diff mbox series

[v3,17/20] ASoC: tlv320dac33: use devm_kmemdup_array()

Message ID 20250203080902.1864382-18-raag.jadav@intel.com (mailing list archive)
State New
Headers show
Series Split devres APIs to device/devres.h and introduce devm_kmemdup_array() | expand

Commit Message

Raag Jadav Feb. 3, 2025, 8:08 a.m. UTC 
Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 sound/soc/codecs/tlv320dac33.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Andy Shevchenko Feb. 3, 2025, 9:52 a.m. UTC | #1 
On Mon, Feb 03, 2025 at 01:38:59PM +0530, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.

...

> -	dac33->reg_cache = devm_kmemdup(&client->dev,
> -					dac33_reg,
> -					ARRAY_SIZE(dac33_reg) * sizeof(u8),
> -					GFP_KERNEL);
> +	dac33->reg_cache = devm_kmemdup_array(&client->dev, dac33_reg, ARRAY_SIZE(dac33_reg),
> +					      sizeof(u8), GFP_KERNEL);

sizeof(*dac33->reg_cache) ?

>  	if (!dac33->reg_cache)
>  		return -ENOMEM;
diff mbox series

Patch

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index fa46f51d4341..3919f8b14995 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -1477,10 +1477,8 @@  static int dac33_i2c_probe(struct i2c_client *client)
 	if (dac33 == NULL)
 		return -ENOMEM;
 
-	dac33->reg_cache = devm_kmemdup(&client->dev,
-					dac33_reg,
-					ARRAY_SIZE(dac33_reg) * sizeof(u8),
-					GFP_KERNEL);
+	dac33->reg_cache = devm_kmemdup_array(&client->dev, dac33_reg, ARRAY_SIZE(dac33_reg),
+					      sizeof(u8), GFP_KERNEL);
 	if (!dac33->reg_cache)
 		return -ENOMEM;