| Message ID | 20250131-gpio-set-array-helper-v1-2-991c8ccb4d6e@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | gpiolib: add gpiods_set_array_value_cansleep | expand |
On Fri, Jan 31, 2025 at 10:24 PM David Lechner <dlechner@baylibre.com> wrote: > > Reduce verbosity by using gpiods_set_array_value_cansleep() instead of > gpiods_set_array_value_cansleep(). Acked-by: Andy Shevchenko <andy@kernel.org> Or if you want me to take it through the auxdisplay tree, please provide the immutable tag/branch for the first patch.
Hi David, Thanks for your patch! On Fri, 31 Jan 2025 at 21:24, David Lechner <dlechner@baylibre.com> wrote: > Reduce verbosity by using gpiods_set_array_value_cansleep() instead of > gpiods_set_array_value_cansleep(). ^^^^^^ gpiod Am I really the first to notice you got this wrong in each and every patch? ;-) Gr{oetje,eeting}s, Geert
On Mon, Feb 3, 2025 at 12:35 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Fri, 31 Jan 2025 at 21:24, David Lechner <dlechner@baylibre.com> wrote: > > Reduce verbosity by using gpiods_set_array_value_cansleep() instead of > > gpiods_set_array_value_cansleep(). > ^^^^^^ > gpiod > > Am I really the first to notice you got this wrong in each and every patch? ;-) Who reads the commit messages? :-)
diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..c158b2c2827415e75d0b122914b8b18c043e8c76 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); + gpiods_set_array_value_cansleep(priv->segment_gpios, values); } static int seg_led_linedisp_get_map_type(struct linedisp *linedisp)
Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner <dlechner@baylibre.com> --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)