| Message ID | 20250131162611.33338-6-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: at91: calao_usb: improve LED description | expand |
On 31/01/2025 at 17:26, Wolfram Sang wrote: > Default DTs should be minimal. It is cumbersome carrying a custom patch > disabling the heartbeat just to use the LED for own cases. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Makes sense on this minimal platform: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks and best regards, Nicolas > --- > arch/arm/boot/dts/microchip/usb_a9260_common.dtsi | 1 - > arch/arm/boot/dts/microchip/usb_a9263.dts | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi b/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi > index 5eb844f2df9d..9672a5626cae 100644 > --- a/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi > +++ b/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi > @@ -123,7 +123,6 @@ leds { > user_led { > label = "user_led"; > gpios = <&pioB 21 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "heartbeat"; > }; > }; > > diff --git a/arch/arm/boot/dts/microchip/usb_a9263.dts b/arch/arm/boot/dts/microchip/usb_a9263.dts > index 45745915b2e1..ef529ec5dd6f 100644 > --- a/arch/arm/boot/dts/microchip/usb_a9263.dts > +++ b/arch/arm/boot/dts/microchip/usb_a9263.dts > @@ -151,7 +151,6 @@ leds { > user_led { > label = "user_led"; > gpios = <&pioB 21 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "heartbeat"; > }; > }; > > -- > 2.45.2 >
diff --git a/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi b/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi index 5eb844f2df9d..9672a5626cae 100644 --- a/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi +++ b/arch/arm/boot/dts/microchip/usb_a9260_common.dtsi @@ -123,7 +123,6 @@ leds { user_led { label = "user_led"; gpios = <&pioB 21 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "heartbeat"; }; }; diff --git a/arch/arm/boot/dts/microchip/usb_a9263.dts b/arch/arm/boot/dts/microchip/usb_a9263.dts index 45745915b2e1..ef529ec5dd6f 100644 --- a/arch/arm/boot/dts/microchip/usb_a9263.dts +++ b/arch/arm/boot/dts/microchip/usb_a9263.dts @@ -151,7 +151,6 @@ leds { user_led { label = "user_led"; gpios = <&pioB 21 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "heartbeat"; }; };
Default DTs should be minimal. It is cumbersome carrying a custom patch disabling the heartbeat just to use the LED for own cases. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm/boot/dts/microchip/usb_a9260_common.dtsi | 1 - arch/arm/boot/dts/microchip/usb_a9263.dts | 1 - 2 files changed, 2 deletions(-)