| Message ID | 20250127213310.2496133-9-wnliu@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | unwind, arm64: add sframe unwinder for kernel | expand |
On 28-01-2025 03:03, Weinan Liu wrote: > Since SFrame is considered as reliable stacktrace, enable livepatch in > arch/arm64/Kconfig > > Signed-off-by: Weinan Liu <wnliu@google.com> > --- > arch/arm64/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 100570a048c5..c292bc73b65c 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -271,6 +271,8 @@ config ARM64 > select HAVE_SOFTIRQ_ON_OWN_STACK > select USER_STACKTRACE_SUPPORT > select VDSO_GETRANDOM > + select HAVE_RELIABLE_STACKTRACE if SFRAME_UNWINDER > + select HAVE_LIVEPATCH if HAVE_DYNAMIC_FTRACE_WITH_ARGS && HAVE_RELIABLE_STACKTRACE > help > ARM 64-bit (AArch64) Linux support. > > @@ -2498,3 +2500,4 @@ source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > > +source "kernel/livepatch/Kconfig" Looks good to me. Reviewed-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>.
On 28-01-2025 03:03, Weinan Liu wrote: > Since SFrame is considered as reliable stacktrace, enable livepatch in > arch/arm64/Kconfig > > Signed-off-by: Weinan Liu <wnliu@google.com> > --- > arch/arm64/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 100570a048c5..c292bc73b65c 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -271,6 +271,8 @@ config ARM64 > select HAVE_SOFTIRQ_ON_OWN_STACK > select USER_STACKTRACE_SUPPORT > select VDSO_GETRANDOM > + select HAVE_RELIABLE_STACKTRACE if SFRAME_UNWINDER > + select HAVE_LIVEPATCH if HAVE_DYNAMIC_FTRACE_WITH_ARGS && HAVE_RELIABLE_STACKTRACE > help > ARM 64-bit (AArch64) Linux support. > > @@ -2498,3 +2500,4 @@ source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > > +source "kernel/livepatch/Kconfig" Will this work for ftrace'd (kprobe'd) function as well?
On Fri, 31 Jan 2025 21:38:46 +0530 Prasanna Kumar T S M <ptsm@linux.microsoft.com> wrote: > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -271,6 +271,8 @@ config ARM64 > > select HAVE_SOFTIRQ_ON_OWN_STACK > > select USER_STACKTRACE_SUPPORT > > select VDSO_GETRANDOM > > + select HAVE_RELIABLE_STACKTRACE if SFRAME_UNWINDER > > + select HAVE_LIVEPATCH if HAVE_DYNAMIC_FTRACE_WITH_ARGS && HAVE_RELIABLE_STACKTRACE > > help > > ARM 64-bit (AArch64) Linux support. > > > > @@ -2498,3 +2500,4 @@ source "drivers/acpi/Kconfig" > > > > source "arch/arm64/kvm/Kconfig" > > > > +source "kernel/livepatch/Kconfig" > > Will this work for ftrace'd (kprobe'd) function as well? What work? The stack walker? It may require updates to the tracing trampolines, but it should be doable just like ORC is. -- Steve
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 100570a048c5..c292bc73b65c 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -271,6 +271,8 @@ config ARM64 select HAVE_SOFTIRQ_ON_OWN_STACK select USER_STACKTRACE_SUPPORT select VDSO_GETRANDOM + select HAVE_RELIABLE_STACKTRACE if SFRAME_UNWINDER + select HAVE_LIVEPATCH if HAVE_DYNAMIC_FTRACE_WITH_ARGS && HAVE_RELIABLE_STACKTRACE help ARM 64-bit (AArch64) Linux support. @@ -2498,3 +2500,4 @@ source "drivers/acpi/Kconfig" source "arch/arm64/kvm/Kconfig" +source "kernel/livepatch/Kconfig"
Since SFrame is considered as reliable stacktrace, enable livepatch in arch/arm64/Kconfig Signed-off-by: Weinan Liu <wnliu@google.com> --- arch/arm64/Kconfig | 3 +++ 1 file changed, 3 insertions(+)