diff mbox series

[kvm-unit-tests,v1] editorconfig: Add max line length setting for commit message and branch description

Message ID 20250131115307.70334-1-mhartmay@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests,v1] editorconfig: Add max line length setting for commit message and branch description | expand

Commit Message

Marc Hartmayer Jan. 31, 2025, 11:53 a.m. UTC
Add max line length setting for commit messages and branch descriptions to
the Editorconfig configuration. Use herefor the same value as used by
checkpatch [1]. See [2] for details about the file 'COMMIT_EDITMSG'.

[1] https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/scripts/checkpatch.pl#L3270
[2] https://git-scm.com/docs/git-commit/2.46.1#Documentation/git-commit.txt-codeGITDIRCOMMITEDITMSGcode

Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
 .editorconfig | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 2e66bb4b9423970ceb6ea195bd8697733bcd9071

Comments

Nico Boehr Feb. 4, 2025, 10:25 a.m. UTC | #1
On Fri Jan 31, 2025 at 12:53 PM CET, Marc Hartmayer wrote:
> Add max line length setting for commit messages and branch descriptions to
> the Editorconfig configuration. Use herefor the same value as used by
> checkpatch [1]. See [2] for details about the file 'COMMIT_EDITMSG'.
>
> [1] https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/scripts/checkpatch.pl#L3270
> [2] https://git-scm.com/docs/git-commit/2.46.1#Documentation/git-commit.txt-codeGITDIRCOMMITEDITMSGcode
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>

I don't use editorconfig, but it seems like a valuable thing to do, hence:

Acked-by: Nico Boehr <nrb@linux.ibm.com>

Thanks!
Thomas Huth March 5, 2025, 3:15 p.m. UTC | #2
On 31/01/2025 12.53, Marc Hartmayer wrote:
> Add max line length setting for commit messages and branch descriptions to
> the Editorconfig configuration. Use herefor the same value as used by
> checkpatch [1]. See [2] for details about the file 'COMMIT_EDITMSG'.
> 
> [1] https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/scripts/checkpatch.pl#L3270
> [2] https://git-scm.com/docs/git-commit/2.46.1#Documentation/git-commit.txt-codeGITDIRCOMMITEDITMSGcode
> 
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
>   .editorconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/.editorconfig b/.editorconfig
> index 46d4ac64f897..03bb16cb9442 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -13,3 +13,6 @@ insert_final_newline = true
>   charset = utf-8
>   indent_style = tab
>   indent_size = 8
> +
> +[{COMMIT_EDITMSG,EDIT_DESCRIPTION}]
> +max_line_length = 75

Thanks, applied now!

  Thomas
diff mbox series

Patch

diff --git a/.editorconfig b/.editorconfig
index 46d4ac64f897..03bb16cb9442 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -13,3 +13,6 @@  insert_final_newline = true
 charset = utf-8
 indent_style = tab
 indent_size = 8
+
+[{COMMIT_EDITMSG,EDIT_DESCRIPTION}]
+max_line_length = 75