diff mbox series

[isar-cip-core,v1,2/3] rules.tmpl: Make ltp rules file as template to make installation path configurable

Message ID 20250203115321.3589084-3-Sai.Sathujoda@toshiba-tsip.com (mailing list archive)
State New
Headers show
Series Make LTP installation path configurable | expand

Commit Message

Sai.Sathujoda@toshiba-tsip.com Feb. 3, 2025, 11:53 a.m. UTC 
From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>

Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
---
 recipes-core/ltp/files/debian/{rules => rules.tmpl} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename recipes-core/ltp/files/debian/{rules => rules.tmpl} (80%)

Comments

Jan Kiszka Feb. 4, 2025, 1:21 p.m. UTC | #1 
On 03.02.25 12:53, Sai.Sathujoda@toshiba-tsip.com wrote:
> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
> 
> Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
> ---
>  recipes-core/ltp/files/debian/{rules => rules.tmpl} | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename recipes-core/ltp/files/debian/{rules => rules.tmpl} (80%)
> 
> diff --git a/recipes-core/ltp/files/debian/rules b/recipes-core/ltp/files/debian/rules.tmpl
> similarity index 80%
> rename from recipes-core/ltp/files/debian/rules
> rename to recipes-core/ltp/files/debian/rules.tmpl
> index 06b9070..918b443 100755
> --- a/recipes-core/ltp/files/debian/rules
> +++ b/recipes-core/ltp/files/debian/rules.tmpl
> @@ -1,7 +1,7 @@
>  #!/usr/bin/make -f
>  export DEB_CFLAGS_MAINT_APPEND  = -Wall  -Wno-format-security
>  
> -LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
> +LTP_CONFIGURE_FLAGS = --prefix=${LTP_INSTALL_PATH}
>  

Missing default value for LTP_INSTALL_PATH - comes with patch 3. The
whole series is in inverse order, in fact.

But making this a build-time configuration will mean that there might be
two binary packages called "ltp-full" that are actually not the same
anymore. Can't we select a path that is writable for all our images? Or,
even better, can't we fix ltp to separate installation from workdir?
BTW, does it matter where this workdir is located, on persistent storage
or on tmpfs?

Jan
diff mbox series

Patch

diff --git a/recipes-core/ltp/files/debian/rules b/recipes-core/ltp/files/debian/rules.tmpl
similarity index 80%
rename from recipes-core/ltp/files/debian/rules
rename to recipes-core/ltp/files/debian/rules.tmpl
index 06b9070..918b443 100755
--- a/recipes-core/ltp/files/debian/rules
+++ b/recipes-core/ltp/files/debian/rules.tmpl
@@ -1,7 +1,7 @@ 
 #!/usr/bin/make -f
 export DEB_CFLAGS_MAINT_APPEND  = -Wall  -Wno-format-security
 
-LTP_CONFIGURE_FLAGS = --prefix=/opt/ltp
+LTP_CONFIGURE_FLAGS = --prefix=${LTP_INSTALL_PATH}
 
 %:
 	dh $@  --with autoreconf