diff mbox series

Documentation/networking: Fix basic node example document ISO 15765-2

Message ID 20250203224720.42530-1-reyders1@gmail.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series Documentation/networking: Fix basic node example document ISO 15765-2 | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2025-02-04--15-00 (tests: 886)

Commit Message

Reyders Morales Feb. 3, 2025, 10:47 p.m. UTC
In the current struct sockaddr_can tp is member of can_addr.
tp is not member of struct sockaddr_can.

Signed-off-by: Reyders Morales <reyders1@gmail.com>
---
 Documentation/networking/iso15765-2.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Oliver Hartkopp Feb. 4, 2025, 7:40 a.m. UTC | #1
On 03.02.25 23:47, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
> 
> Signed-off-by: Reyders Morales <reyders1@gmail.com>

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Thanks!

> ---
>   Documentation/networking/iso15765-2.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>   
>     addr.can_family = AF_CAN;
>     addr.can_ifindex = if_nametoindex("can0");
> -  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> -  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>   
>     ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
>     if (ret < 0)
Simon Horman Feb. 4, 2025, 1:45 p.m. UTC | #2
On Mon, Feb 03, 2025 at 11:47:20PM +0100, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
> 
> Signed-off-by: Reyders Morales <reyders1@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
index 0e9d96074178..37ebb2c417cb 100644
--- a/Documentation/networking/iso15765-2.rst
+++ b/Documentation/networking/iso15765-2.rst
@@ -369,8 +369,8 @@  to their default.
 
   addr.can_family = AF_CAN;
   addr.can_ifindex = if_nametoindex("can0");
-  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
-  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
+  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
+  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
 
   ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
   if (ret < 0)