| Message ID | Z6F3KZVfnAZ2FoJm@kspp (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 33b565fa2bc0af2d5b23b0fd954460b0b25b9280 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,next] net: atlantic: Avoid -Wflex-array-member-not-at-end warnings | expand |
On Tue, Feb 04, 2025 at 12:40:49PM +1030, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Remove unused flexible-array member `buf` and, with this, fix the following > warnings: > drivers/net/ethernet/aquantia/atlantic/aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > drivers/net/ethernet/aquantia/atlantic/hw_atl/../aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Suggested-by: Igor Russkikh <irusskikh@marvell.com> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > Changes in v2: > - Remove unused flex-array member. (Igor) > > v1: > - Link: https://lore.kernel.org/linux-hardening/ZrDwoVKH8d6TdVxn@cute/ > > drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h > index f5901f8e3907..f6b990b7f5b4 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h > +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h > @@ -226,7 +226,6 @@ struct __packed offload_info { > struct offload_port_info ports; > struct offload_ka_info kas; > struct offload_rr_info rrs; > - u8 buf[]; > }; Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > > struct __packed hw_atl_utils_fw_rpc { > -- > 2.43.0 >
On Tue, Feb 04, 2025 at 12:40:49PM +1030, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Remove unused flexible-array member `buf` and, with this, fix the following > warnings: > drivers/net/ethernet/aquantia/atlantic/aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > drivers/net/ethernet/aquantia/atlantic/hw_atl/../aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Suggested-by: Igor Russkikh <irusskikh@marvell.com> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > Changes in v2: > - Remove unused flex-array member. (Igor) > > v1: > - Link: https://lore.kernel.org/linux-hardening/ZrDwoVKH8d6TdVxn@cute/ Reviewed-by: Simon Horman <horms@kernel.org>
> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Remove unused flexible-array member `buf` and, with this, fix the following warnings: drivers/net/ethernet/aquantia/atlantic/aq_hw. h: 197: 36: > Remove unused flexible-array member `buf` and, with this, fix the following Thanks, Gustavo, for posting this. Reviewed-by: Igor Russkikh <irusskikh@marvell.com> Igor
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 4 Feb 2025 12:40:49 +1030 you wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Remove unused flexible-array member `buf` and, with this, fix the following > warnings: > drivers/net/ethernet/aquantia/atlantic/aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > drivers/net/ethernet/aquantia/atlantic/hw_atl/../aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > [...] Here is the summary with links: - [v2,next] net: atlantic: Avoid -Wflex-array-member-not-at-end warnings https://git.kernel.org/netdev/net-next/c/33b565fa2bc0 You are awesome, thank you!
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h index f5901f8e3907..f6b990b7f5b4 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h @@ -226,7 +226,6 @@ struct __packed offload_info { struct offload_port_info ports; struct offload_ka_info kas; struct offload_rr_info rrs; - u8 buf[]; }; struct __packed hw_atl_utils_fw_rpc {
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Remove unused flexible-array member `buf` and, with this, fix the following warnings: drivers/net/ethernet/aquantia/atlantic/aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] drivers/net/ethernet/aquantia/atlantic/hw_atl/../aq_hw.h:197:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] Suggested-by: Igor Russkikh <irusskikh@marvell.com> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- Changes in v2: - Remove unused flex-array member. (Igor) v1: - Link: https://lore.kernel.org/linux-hardening/ZrDwoVKH8d6TdVxn@cute/ drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h | 1 - 1 file changed, 1 deletion(-)